Summary: | [ATK] Embed the AtkSocket as soon as we receive the plug ID | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, bugs-noreply, ews-watchlist, gustavo, jdiggs, mario, mcatanzaro | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 196535 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-04-03 05:43:59 PDT
Created attachment 366592 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 366592 [details] Patch Attachment 366592 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11750608 Number of test failures exceeded the failure limit. Created attachment 366597 [details]
Archive of layout-test-results from ews549 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews549 Port: win-future Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit
Comment on attachment 366592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366592&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1236 > // Set the parent not to break bottom-up navigation. Might as well fix this while you're at it: "to not break" Committed r243861: <https://trac.webkit.org/changeset/243861> Late-to-the-party drive-by review, just to confirm I checked this: lgtm |