Bug 196534

Summary: [ATK] Embed the AtkSocket as soon as we receive the plug ID
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gustavo, jdiggs, mario, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196535    
Attachments:
Description Flags
Patch
mcatanzaro: review+
Archive of layout-test-results from ews549 for win-future none

Carlos Garcia Campos
Reported 2019-04-03 05:43:59 PDT
We are currently storing the ID and waiting for the next time get_accessible is called to embed the socket. We can simply embed the socket when the plug ID is received.
Attachments
Patch (4.25 KB, patch)
2019-04-03 05:45 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews549 for win-future (5.64 MB, application/zip)
2019-04-03 06:46 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-04-03 05:45:56 PDT
Created attachment 366592 [details] Patch
EWS Watchlist
Comment 2 2019-04-03 05:49:15 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS Watchlist
Comment 3 2019-04-03 06:46:37 PDT
Comment on attachment 366592 [details] Patch Attachment 366592 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11750608 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2019-04-03 06:46:39 PDT
Created attachment 366597 [details] Archive of layout-test-results from ews549 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews549 Port: win-future Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit
Michael Catanzaro
Comment 5 2019-04-03 08:07:13 PDT
Comment on attachment 366592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366592&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1236 > // Set the parent not to break bottom-up navigation. Might as well fix this while you're at it: "to not break"
Carlos Garcia Campos
Comment 6 2019-04-03 22:50:29 PDT
Committed r243861: <https://trac.webkit.org/changeset/243861>
Mario Sanchez Prada
Comment 7 2019-04-05 01:38:06 PDT
Late-to-the-party drive-by review, just to confirm I checked this: lgtm
Note You need to log in before you can comment on or make changes to this bug.