Bug 196462

Summary: Resetting quota should take into account third party origins
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2019-04-01 14:01:28 PDT
Resetting quota should take into account third party origins where the quota is smaller.
Comment 1 youenn fablet 2019-04-01 14:20:16 PDT
Created attachment 366422 [details]
Patch
Comment 2 youenn fablet 2019-04-02 10:42:15 PDT
Created attachment 366501 [details]
Patch
Comment 3 Geoffrey Garen 2019-04-02 18:44:29 PDT
Comment on attachment 366501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366501&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:-2037
> -    // FIXME: Pass default third party quota as a parameter.

I think this is still worth fixing. A hard-coded / 10 is probably not the best policy.
Comment 4 youenn fablet 2019-04-03 09:32:29 PDT
> I think this is still worth fixing. A hard-coded / 10 is probably not the
> best policy.

Agreed, filed https://bugs.webkit.org/show_bug.cgi?id=196543
Comment 5 WebKit Commit Bot 2019-04-03 10:00:41 PDT
Comment on attachment 366501 [details]
Patch

Clearing flags on attachment: 366501

Committed r243806: <https://trac.webkit.org/changeset/243806>
Comment 6 WebKit Commit Bot 2019-04-03 10:00:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-04-03 10:01:26 PDT
<rdar://problem/49561975>