Bug 196543 – Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters

[youenn fablet]

Created attachment 366616 [details]
Patch

[youenn fablet]

Created attachment 366629 [details]
Patch

[youenn fablet]

ping review

[Alex Christensen]

Comment on attachment 366629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366629&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:466
> +    auto& managers =  m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] {

It seems like it would be even better to have the NetworkSession own its own storage quota.

[youenn fablet]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 366629 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366629&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:466
> > +    auto& managers =  m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] {
> 
> It seems like it would be even better to have the NetworkSession own its own
> storage quota.

It is true that NetworkProcess has 9 HashMap keyed by SessionID...
NetworkSession might indeed be a better place to put all these various values.

[WebKit Commit Bot]

Comment on attachment 366629 [details]
Patch

Clearing flags on attachment: 366629

Committed r243911: <https://trac.webkit.org/changeset/243911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49624690>