Bug 196543 - Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
Summary: Pass storage quota parameters from UIProcess to NetworkProcess as part of Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 09:32 PDT by youenn fablet
Modified: 2019-04-04 15:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.88 KB, patch)
2019-04-03 09:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (27.85 KB, patch)
2019-04-03 12:11 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-03 09:32:07 PDT 
Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
Comment 1 youenn fablet 2019-04-03 09:47:11 PDT 
Created attachment 366616 [details]
Patch
Comment 2 youenn fablet 2019-04-03 12:11:03 PDT 
Created attachment 366629 [details]
Patch
Comment 3 youenn fablet 2019-04-04 14:00:02 PDT 
ping review
Comment 4 Alex Christensen 2019-04-04 14:29:31 PDT 
Comment on attachment 366629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366629&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:466
> +    auto& managers =  m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] {

It seems like it would be even better to have the NetworkSession own its own storage quota.
Comment 5 youenn fablet 2019-04-04 14:39:00 PDT 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 366629 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366629&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:466
> > +    auto& managers =  m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] {
> 
> It seems like it would be even better to have the NetworkSession own its own
> storage quota.

It is true that NetworkProcess has 9 HashMap keyed by SessionID...
NetworkSession might indeed be a better place to put all these various values.
Comment 6 WebKit Commit Bot 2019-04-04 15:07:15 PDT 
Comment on attachment 366629 [details]
Patch

Clearing flags on attachment: 366629

Committed r243911: <https://trac.webkit.org/changeset/243911>
Comment 7 WebKit Commit Bot 2019-04-04 15:07:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-04-04 15:08:21 PDT 
<rdar://problem/49624690>