Bug 196462 - Resetting quota should take into account third party origins
Summary: Resetting quota should take into account third party origins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-01 14:01 PDT by youenn fablet
Modified: 2019-04-03 10:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.83 KB, patch)
2019-04-01 14:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (9.40 KB, patch)
2019-04-02 10:42 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-01 14:01:28 PDT 
Resetting quota should take into account third party origins where the quota is smaller.
Comment 1 youenn fablet 2019-04-01 14:20:16 PDT 
Created attachment 366422 [details]
Patch
Comment 2 youenn fablet 2019-04-02 10:42:15 PDT 
Created attachment 366501 [details]
Patch
Comment 3 Geoffrey Garen 2019-04-02 18:44:29 PDT 
Comment on attachment 366501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366501&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:-2037
> -    // FIXME: Pass default third party quota as a parameter.

I think this is still worth fixing. A hard-coded / 10 is probably not the best policy.
Comment 4 youenn fablet 2019-04-03 09:32:29 PDT 
> I think this is still worth fixing. A hard-coded / 10 is probably not the
> best policy.

Agreed, filed https://bugs.webkit.org/show_bug.cgi?id=196543
Comment 5 WebKit Commit Bot 2019-04-03 10:00:41 PDT 
Comment on attachment 366501 [details]
Patch

Clearing flags on attachment: 366501

Committed r243806: <https://trac.webkit.org/changeset/243806>
Comment 6 WebKit Commit Bot 2019-04-03 10:00:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-04-03 10:01:26 PDT 
<rdar://problem/49561975>