Bug 196152

Summary:

Placate exception check validation in constructJSWebAssemblyLinkError().

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dominik.infuehr, ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	msaboff: review+

Description Mark Lam 2019-03-22 10:08:40 PDT

<rdar://problem/49145257>

Comment 1 Radar WebKit Bug Importer 2019-03-22 10:10:43 PDT

<rdar://problem/49157806>

Comment 2 Mark Lam 2019-03-22 10:12:00 PDT

<rdar://problem/49145257>

Comment 3 Mark Lam 2019-03-22 10:13:54 PDT

Created attachment 365739 [details]
proposed patch.

Comment 4 Michael Saboff 2019-03-22 10:17:13 PDT

Comment on attachment 365739 [details]
proposed patch.

r=me

Comment 5 Mark Lam 2019-03-22 10:22:19 PDT

Thanks for the review.  Landed in r243386: <http://trac.webkit.org/r243386>.

Comment 6 Dominik Inführ 2019-03-24 08:41:00 PDT

web-assembly-link-error-exception-check.js is failing on 32-bit systems because of missing WASM support. I've uploaded a patch that moves this test into JSTests/wasm/stress: https://bugs.webkit.org/show_bug.cgi?id=196187