Bug 196105

Summary: Make a SelectValue subclass of B3::Value
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196091    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Robin Morisset 2019-03-21 12:22:56 PDT 
Mostly useful for https://bugs.webkit.org/show_bug.cgi?id=196091
It also allows us to give names to the children (cond/ifTrue/ifFalse).
Comment 1 Robin Morisset 2019-03-21 12:27:01 PDT 
Created attachment 365589 [details]
Patch

It passes testb3 in Release mode.
The select tests also pass in Debug mode, but I could not test the whole file in Debug mode because of https://bugs.webkit.org/show_bug.cgi?id=196103.
Comment 2 Robin Morisset 2019-03-21 13:08:06 PDT 
Created attachment 365600 [details]
Patch

Remembering to svn add the new files.
Comment 3 EWS Watchlist 2019-03-21 13:13:30 PDT 
Attachment 365600 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3Value.h:419:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Robin Morisset 2019-03-21 13:56:43 PDT 
Created attachment 365611 [details]
Patch

I had forgotten to update FTLOutput.cpp and WASMB3IRGenerator.cpp
Comment 5 Robin Morisset 2019-03-21 14:06:17 PDT 
Phil suggested a better approach in https://bugs.webkit.org/show_bug.cgi?id=196091