Bug 196105

Summary: Make a SelectValue subclass of B3::Value
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196091    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Robin Morisset
Reported 2019-03-21 12:22:56 PDT
Mostly useful for https://bugs.webkit.org/show_bug.cgi?id=196091 It also allows us to give names to the children (cond/ifTrue/ifFalse).
Attachments
Patch (24.44 KB, patch)
2019-03-21 12:27 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (28.77 KB, patch)
2019-03-21 13:08 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (30.42 KB, patch)
2019-03-21 13:56 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-03-21 12:27:01 PDT
Created attachment 365589 [details] Patch It passes testb3 in Release mode. The select tests also pass in Debug mode, but I could not test the whole file in Debug mode because of https://bugs.webkit.org/show_bug.cgi?id=196103.
Robin Morisset
Comment 2 2019-03-21 13:08:06 PDT
Created attachment 365600 [details] Patch Remembering to svn add the new files.
EWS Watchlist
Comment 3 2019-03-21 13:13:30 PDT
Attachment 365600 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3Value.h:419: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Robin Morisset
Comment 4 2019-03-21 13:56:43 PDT
Created attachment 365611 [details] Patch I had forgotten to update FTLOutput.cpp and WASMB3IRGenerator.cpp
Robin Morisset
Comment 5 2019-03-21 14:06:17 PDT
Phil suggested a better approach in https://bugs.webkit.org/show_bug.cgi?id=196091
Note You need to log in before you can comment on or make changes to this bug.