Bug 195945

Summary:

[ews-build] Improve summary for PrintConfiguration step

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, ews-watchlist, jbedard, lforschler, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196780
https://bugs.webkit.org/show_bug.cgi?id=202163

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none
Patch	lforschler: review+
Screenshot with this fix	none

Description Aakash Jain 2019-03-19 07:46:41 PDT

The summary automatically generated by Buildbot for PrintConfiguration looks like: 'xcodebuild -sdk ...'. This isn't very readable/informative. We should improve this.

Buildbot doesn't seem to respect descriptionDone for steps.ShellSequence class. Reference: https://github.com/buildbot/buildbot/issues/4088

Comment 1 Aakash Jain 2019-03-19 07:48:33 PDT

Created attachment 365155 [details]
Patch

Comment 2 EWS Watchlist 2019-03-19 07:51:14 PDT Comment hidden (obsolete)

Attachment 365155 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:771:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Aakash Jain 2019-03-19 08:08:29 PDT

Created attachment 365157 [details]
Patch

Comment 4 EWS Watchlist 2019-03-19 08:10:04 PDT Comment hidden (obsolete)

Attachment 365157 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:771:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Alexey Proskuryakov 2019-03-19 09:13:37 PDT

Can you attach a screenshot for the new behavior? 'Printed configuration' is more readable than 'xcodebuild -sdk ...', but not informative at all. Would it make sense for the step summary should contain some of the configuration details perhaps?

Comment 6 EWS Watchlist 2019-03-19 09:54:31 PDT Comment hidden (obsolete)

Comment on attachment 365157 [details]
Patch

Attachment 365157 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11566659

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

Comment 7 EWS Watchlist 2019-03-19 09:54:33 PDT Comment hidden (obsolete)

Created attachment 365175 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 8 Aakash Jain 2019-03-19 13:13:55 PDT

Created attachment 365218 [details]
Patch

Comment 9 EWS Watchlist 2019-03-19 13:17:45 PDT Comment hidden (obsolete)

Attachment 365218 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:767:  [PrintConfiguration.__init__] Instance of 'PrintConfiguration' has no 'addLogObserver' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:789:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:800:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'getProperty' member  [pylint/E1101] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Aakash Jain 2019-03-19 13:39:23 PDT

Created attachment 365221 [details]
Patch

Comment 11 EWS Watchlist 2019-03-19 13:41:50 PDT Comment hidden (obsolete)

Attachment 365221 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:767:  [PrintConfiguration.__init__] Instance of 'PrintConfiguration' has no 'addLogObserver' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:795:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'results' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:806:  [PrintConfiguration.getResultSummary] Instance of 'PrintConfiguration' has no 'getProperty' member  [pylint/E1101] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Aakash Jain 2019-03-19 14:57:02 PDT

Created attachment 365233 [details]
Screenshot with this fix

Comment 13 Aakash Jain 2019-03-19 14:57:28 PDT

(In reply to Alexey Proskuryakov from comment #5)
> Can you attach a screenshot for the new behavior?
Attached.

> Would it make sense for the step summary should contain some of the configuration details perhaps?
Updated the patch to extract and print the configuration details.

Sample summary: OS: High Sierra (10.13.6), Xcode: 12.2

Comment 14 Lucas Forschler 2019-03-19 15:04:42 PDT

Comment on attachment 365221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365221&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:774
> +            return 'Unkown'

typo

> Tools/BuildSlaveSupport/ews-build/steps.py:787
> +        }

do we need to go back this far?

Comment 15 Aakash Jain 2019-03-19 15:38:51 PDT

> do we need to go back this far?
Not really, but I don't see any harm as well. External machines would be connecting to this EWS which might be running any old OS.

Comment 16 Aakash Jain 2019-03-19 16:02:28 PDT

Committed r243177: <https://trac.webkit.org/changeset/243177>

Comment 17 Radar WebKit Bug Importer 2019-03-19 16:03:34 PDT

<rdar://problem/49039926>