Bug 195905 – Remove the SVG tear off objects for SVGPoint, SVGPointList and SVGAnimatedPointList

• Component: SVG
• Status: RESOLVED FIXED

[Said Abou-Hallawa]

This requires adding new classes for the SVG property and SVG property list types. It also requires new accessor, new animator and new animation function for accessing and animating the SVGAnimatedPointList. SVGPointList will not be backed by SVGPointListValues.

[Said Abou-Hallawa]

Created attachment 365048 [details]
Patch

[Said Abou-Hallawa]

Created attachment 365050 [details]
Patch for review

[Jon Lee]

Is a new patch going to be uploaded?

[Said Abou-Hallawa]

Created attachment 365520 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 365520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365520&action=review

> Source/WebCore/svg/SVGPointList.h:82
> +            append(SVGPoint::create(FloatPoint(xPos, yPos)));

append(SVGPoint::create({ xPos, yPos }));

[Radar WebKit Bug Importer]

<rdar://problem/49121824>

[Said Abou-Hallawa]

Committed r243336: <https://trac.webkit.org/changeset/243336>

[Michael Catanzaro]

It introduced a warning spam. Please remember to be careful about pessimizing move:

DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:572:64: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
  572 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                                                                ^
../../Source/WebCore/svg/properties/SVGPropertyList.h:120:16: note: in expansion of macro ‘WTFMove’
  120 |         return WTFMove(item);
      |                ^~~~~~~
DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:572:64: note: remove ‘std::move’ call
  572 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value)
      |                                                                ^
../../Source/WebCore/svg/properties/SVGPropertyList.h:120:16: note: in expansion of macro ‘WTFMove’
  120 |         return WTFMove(item);
      |                ^~~~~~~

[Michael Catanzaro]

Committed r243421: <https://trac.webkit.org/changeset/243421>