| Summary: | [WPE][GTK] Building with experimental features enabled from tarball fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | ASSIGNED --- | ||
| Severity: | Normal | CC: | cgarcia, lforschler, mcatanzaro, pnormand, zan |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/Igalia/meta-webkit/issues/70 | ||
| Bug Depends on: | 196222, 196223 | ||
| Bug Blocks: | |||
Trying to build with experimental features enabled from tarballs would
also fail for the GTK port, and not only due to the “ThirdParty/openvr/”
directory being missing. In “Tools/{gtk,wpe}/manifest.txt.in” we have
the following snippet for both ports:
directory Source
exclude Source/JavaScriptCore/tests
exclude Source/ThirdParty/capstone
exclude Source/ThirdParty/libwebrtc
exclude Source/ThirdParty/qunit
exclude Source/ThirdParty/openvr
This means that trying to build the WebRTC support (which is also an
experimental feature) will fail as well. Should we actually add BOTH
the “ThirdParty/openvr/” and “ThirdParty/libwebrtc/” subdirectories
to tarballs?
(CC'd some of people more involved with the GTK and WPE port releases, to get them into the discussion.) (In reply to Adrian Perez from comment #1) > This means that trying to build the WebRTC support (which is also an > experimental feature) will fail as well. Should we actually add BOTH > the “ThirdParty/openvr/” and Our experimental features flag is intended for features under active development. OpenVR does not qualify, so I would just disable it unconditionally. > “ThirdParty/libwebrtc/” subdirectories to tarballs? We agreed not to include it in tarballs until we have removed the dependency on BoringSSL. I don't see why experimental features would be expected to work in tarballs anyway. Isn't this build flag PRIVATE so users cannot see it? We have agreed to make a builds from tarballs be possible when ENABLE_EXPERIMENTAL_FEATURES is enabled; in particular: - Figure out the minimum set of sources needed to be included in release tarballs for libwebrtc, see bug #196222 - Make the WebVR support not depend on ENABLE_EXPERIMENTAL_FEATURES and also do not include for now the needed third party code in tarballs, see bug #196223 This is left as tracker bug for any build failure *from tarballs* (as generated by “make dist” or “ninja dist”) when experimental features are enabled. |
It seems that the “ThirdParty/openvr” subdirectory not being included in tarballs is the culprit: CMake Error at Source/CMakeLists.txt:28 (add_subdirectory): add_subdirectory given source "ThirdParty/openvr" which is not an existing directory. Originally reported at https://github.com/Igalia/meta-webkit/issues/70