Bug 196222 - [WPE][GTK] Include the needed parts of ThidParty/libwebrtc in tarballs
Summary: [WPE][GTK] Include the needed parts of ThidParty/libwebrtc in tarballs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks: 195889
  Show dependency treegraph
 
Reported: 2019-03-25 15:50 PDT by Adrian Perez
Modified: 2019-09-27 11:50 PDT (History)
7 users (show)

See Also:


Attachments
WIP Patch (20.84 KB, patch)
2019-03-25 17:23 PDT, Adrian Perez
aperez: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-03-25 15:50:43 PDT
Eventually, we want to be able to make builds with WebRTC support
enabled from release tarballs.
Comment 1 Adrian Perez 2019-03-25 17:23:16 PDT
Created attachment 365925 [details]
WIP Patch


First pass at having the libwebrtc sources in the tarballs. With
this it is already possible to build the WPE and GTK ports from
their tarballs passing -DENABLE_WEB_RTC=ON to CMake. The tarballs
are still bloated (~50 MiB) and include many things which are not
strictly needed, so I will look into improving that.
Comment 2 Carlos Alberto Lopez Perez 2019-09-27 06:10:55 PDT
I would like to test this but I'm unable to correctly execute the make-dist script.

Do you have an example of how this script is executed to create release tarballs?
Comment 3 Carlos Garcia Campos 2019-09-27 06:18:43 PDT
make-dist -c -s <source-dir> path/to/manifest/file

I usually run it from WebKitBuild/Release, so I do:

$ make-dist -c -s../../ manifest.txt
Comment 4 Michael Catanzaro 2019-09-27 07:19:57 PDT
If you include this in tarballs before removing BoringSSL, people will build with it enabled, and GPL violations will result.
Comment 5 Adrian Perez 2019-09-27 11:24:58 PDT
(In reply to Carlos Garcia Campos from comment #3)
> make-dist -c -s <source-dir> path/to/manifest/file
> 
> I usually run it from WebKitBuild/Release, so I do:
> 
> $ make-dist -c -s../../ manifest.txt

Alternatively, pass “-DDEVELOPER_MODE=ON” to CMake, and then
use “make dist” (or “ninja dist”).

The patch is very WIP and doesn't work. When I stopped working
on it it was at the point where a bit over a half of libwebrtc
would build from a WebKitGTK tarball. It needs work.

The BoringSSL issue mentioned by Michael is *very* real, so the
idea here was to include the needed sources in the tarball, but
leave the WebRTC support disabled by default, and making CMake
spit out a big fat warning about the licensing when enabled.
Comment 6 Michael Catanzaro 2019-09-27 11:50:27 PDT
$0.02: nobody will read what CMake prints. Options we provide will be enabled somewhere.