Bug 196223 - [WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_FEATURES
Summary: [WPE][GTK] Make building WebVR (w/OpenVR) not depend on ENABLE_EXPERIMENTAL_F...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: 195889
  Show dependency tree / graph
 
Reported: 2019-03-25 15:54 PDT by Adrian Perez
Modified: 2019-03-25 19:30 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2019-03-25 17:27 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-03-25 15:54:35 PDT 
Features that depend on ENABLE_EXPERIMENTAL_FEATURES ideally should
be buildable from release tarballs. If a feature is in development
(or *very* experimental) and we do not want to include the sources
needed to build it in release tarballs, then it should not depend on
ENABLE_EXPERIMENTAL_FEATURES.

(Note that this would just remove the dependency, the feature would
still be buildable from a WebKit checkout by explicitly enabling it,
of course.)
Comment 1 Adrian Perez 2019-03-25 17:27:42 PDT 
Created attachment 365927 [details]
Patch
Comment 2 WebKit Commit Bot 2019-03-25 19:18:19 PDT 
Comment on attachment 365927 [details]
Patch

Clearing flags on attachment: 365927

Committed r243481: <https://trac.webkit.org/changeset/243481>
Comment 3 WebKit Commit Bot 2019-03-25 19:18:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-25 19:30:54 PDT 
<rdar://problem/49241316>