Bug 195865

Summary: Web Inspector: Timeline: lazily create the agent
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, sroberts, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 195590, 195591, 195592    
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2019-03-17 14:47:29 PDT 
.
Comment 1 Radar WebKit Bug Importer 2019-03-17 15:01:08 PDT 
<rdar://problem/48965403>
Comment 2 Devin Rousso 2019-03-17 16:24:32 PDT 
Created attachment 364981 [details]
Patch
Comment 3 Joseph Pecoraro 2019-03-18 13:15:43 PDT 
Comment on attachment 364981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364981&action=review

r=me

> Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:719
> +    record->setString("frameId", pageAgent->frameId(frame));

Nit: "frameId"_s to use ASCIILiteral construction.
Comment 4 Devin Rousso 2019-03-18 14:14:22 PDT 
Created attachment 365061 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-18 17:31:30 PDT 
Comment on attachment 365061 [details]
Patch

Clearing flags on attachment: 365061

Committed r243119: <https://trac.webkit.org/changeset/243119>
Comment 6 WebKit Commit Bot 2019-03-18 17:31:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Shawn Roberts 2019-03-19 08:32:53 PDT 
This commit is causing 2 new failures in the following tests on all of Mac

inspector/timeline/line-column.html
inspector/timeline/setInstruments-programmatic-capture.html

Reproduced with:

run-webkit-tests inspector/timeline/setInstruments-programmatic-capture.html --iterations 10 -f 
run-webkit-tests inspector/timeline/line-column.html -- iterations 10 -f

all iterations produce a text diff failure in 243119
all iterations pass in 243116


Flakiness Dashboard: 

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Fline-column.html%20inspector%2Ftimeline%2FsetInstruments-programmatic-capture.html

Diff:

https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r243136%20(3171)/inspector/timeline/line-column-diff.txt

https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r243136%20(3171)/inspector/timeline/setInstruments-programmatic-capture-diff.txt
Comment 8 Devin Rousso 2019-03-19 11:42:10 PDT 
(In reply to Shawn Roberts from comment #7)
> This commit is causing 2 new failures in the following tests on all of Mac
> 
> inspector/timeline/line-column.html
> inspector/timeline/setInstruments-programmatic-capture.html
> 
> Reproduced with:
> 
> run-webkit-tests inspector/timeline/setInstruments-programmatic-capture.html
> --iterations 10 -f 
> run-webkit-tests inspector/timeline/line-column.html -- iterations 10 -f
> 
> all iterations produce a text diff failure in 243119
> all iterations pass in 243116
> 
> 
> Flakiness Dashboard: 
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=inspector%2Ftimeline%2Fline-column.
> html%20inspector%2Ftimeline%2FsetInstruments-programmatic-capture.html
> 
> Diff:
> 
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/
> r243136%20(3171)/inspector/timeline/line-column-diff.txt
> 
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/
> r243136%20(3171)/inspector/timeline/setInstruments-programmatic-capture-diff.
> txt
Fixed in followup r243155 <http://trac.webkit.org/changeset/243155>.