Bug 195864

Summary: [WHLSL] read modify write expressions do no work as expected
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, justin_fan, rmorisset, saam, tsavell, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 199037    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
WIP
none
WIP
none
Patch none

Description Myles C. Maxfield 2019-03-17 13:16:20 PDT 
Something is amiss.
Comment 1 Radar WebKit Bug Importer 2019-05-13 17:07:24 PDT 
<rdar://problem/50746278>
Comment 2 Robin Morisset 2019-05-14 12:33:26 PDT 
Created attachment 369881 [details]
Patch
Comment 3 Myles C. Maxfield 2019-05-14 13:41:45 PDT 
Comment on attachment 369881 [details]
Patch

Looks like this was just a stupid mistake I made. Stupid mistakes like this are why the test suite is so important.
Comment 4 WebKit Commit Bot 2019-05-14 14:50:00 PDT 
Comment on attachment 369881 [details]
Patch

Clearing flags on attachment: 369881

Committed r245312: <https://trac.webkit.org/changeset/245312>
Comment 5 WebKit Commit Bot 2019-05-14 14:50:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Saam Barati 2019-05-21 14:46:20 PDT 
This isn't actually fixed yet.

this doesn't parse:

```
int bar() {
    int foo;
    foo++;
}
```
Comment 7 Saam Barati 2019-06-19 13:08:36 PDT 
I think I had a crash yesterday when writing a loop like this:

```
for (uint I = 0; I < n; I++)
```

and had to instead write it like
```
for (uint I = 0; I < n; I = I + 1)
```
Comment 8 Myles C. Maxfield 2019-06-20 10:51:46 PDT 
Created attachment 372569 [details]
WIP
Comment 9 Myles C. Maxfield 2019-06-20 11:06:08 PDT 
Comment on attachment 372569 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=372569&action=review

> LayoutTests/webgpu/whlsl-read-modify-write.html:12
> +    buffer1 = buffer[0]++;

buffer[1] = buffer[0]++;
Comment 10 Myles C. Maxfield 2019-06-20 11:08:24 PDT 
Created attachment 372572 [details]
WIP
Comment 11 Myles C. Maxfield 2019-06-21 00:14:32 PDT 
Created attachment 372619 [details]
Patch
Comment 12 WebKit Commit Bot 2019-06-21 09:59:21 PDT 
Comment on attachment 372619 [details]
Patch

Clearing flags on attachment: 372619

Committed r246681: <https://trac.webkit.org/changeset/246681>
Comment 13 WebKit Commit Bot 2019-06-21 09:59:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 Truitt Savell 2019-06-21 12:57:12 PDT 
Looks like the new test webgpu/whlsl-read-modify-write.html
added in https://trac.webkit.org/changeset/246681/webkit

is missing results on WK2

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl-read-modify-write.html
Comment 15 Myles C. Maxfield 2019-06-21 14:02:46 PDT 
Committed r246696: <https://trac.webkit.org/changeset/246696>