|Summary:||[ews-build] Don't run clean builds on EWS builders|
|Product:||WebKit||Reporter:||Aakash Jain <aakash_jain>|
|Component:||Tools / Tests||Assignee:||Aakash Jain <aakash_jain>|
|Severity:||Normal||CC:||aakash_jain, ap, commit-queue, dewei_zhu, ggaren, jbedard, kocsen_chung, lforschler, webkit-bug-importer|
Description Aakash Jain 2019-03-16 08:48:25 PDT
Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. The current EWS also doesn't run clean builds, ews-build should do the same.
Comment 3 WebKit Commit Bot 2019-03-16 20:50:52 PDT
Comment on attachment 364932 [details] Patch Clearing flags on attachment: 364932 Committed r243050: <https://trac.webkit.org/changeset/243050>
Comment 4 WebKit Commit Bot 2019-03-16 20:50:53 PDT
All reviewed patches have been landed. Closing bug.
Comment 6 Jonathan Bedard 2019-03-18 09:01:50 PDT
Question about this change: What happens if we need a clean build for some reason? Is there a mechanism to, for example, force a clean build if the build fails?
Comment 7 Jonathan Bedard 2019-03-18 11:08:24 PDT
(In reply to Jonathan Bedard from comment #6) > Question about this change: What happens if we need a clean build for some > reason? Is there a mechanism to, for example, force a clean build if the > build fails? Discussed this on IRC with Aakash. Turns out, the code which cleans up after a patch fails to build removes the build directory. So we shouldn't need to do anything special to handle this case.