Bug 195851

Summary:

[ews-build] Don't run clean builds on EWS builders

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, ggaren, jbedard, kocsen_chung, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196897

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2019-03-16 08:48:25 PDT

Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. The current EWS also doesn't run clean builds, ews-build should do the same.

Comment 1 Aakash Jain 2019-03-16 08:49:16 PDT

Created attachment 364932 [details]
Patch

Comment 2 Geoffrey Garen 2019-03-16 13:48:41 PDT

Comment on attachment 364932 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2019-03-16 20:50:52 PDT

Comment on attachment 364932 [details]
Patch

Clearing flags on attachment: 364932

Committed r243050: <https://trac.webkit.org/changeset/243050>

Comment 4 WebKit Commit Bot 2019-03-16 20:50:53 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-03-16 20:51:16 PDT

<rdar://problem/48958641>

Comment 6 Jonathan Bedard 2019-03-18 09:01:50 PDT

Question about this change: What happens if we need a clean build for some reason? Is there a mechanism to, for example, force a clean build if the build fails?

Comment 7 Jonathan Bedard 2019-03-18 11:08:24 PDT

(In reply to Jonathan Bedard from comment #6)
> Question about this change: What happens if we need a clean build for some
> reason? Is there a mechanism to, for example, force a clean build if the
> build fails?

Discussed this on IRC with Aakash. Turns out, the code which cleans up after a patch fails to build removes the build directory. So we shouldn't need to do anything special to handle this case.