Bug 195607

Summary: Remove OS X Server QuickTime plugin quirks
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Plug-insAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, bfulgham, cdumez, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=61229
Attachments:
Description Flags
Cleanup bfulgham: review+

Ryosuke Niwa
Reported 2019-03-11 22:56:44 PDT
https://trac.webkit.org/r87244 added a site specific quirk for Mac OS X Sever wiki pages. However, the issue has since been resolved as of OS X Mountain Lion. Apple has ended the support of this operating system in September 2015, and iTunes' support subsequently ended in August 2016. Furthermore, the latest versions of Safari no longer supports non-Flash plugins. So the only scenario in which this code will be triggered is with custom WKWebView / WebKitLegacy app which loads OS X Server pages running OS X Mountain Lion or earlier. Given these, I think we can remove this site specific quirk.
Attachments
Cleanup (3.89 KB, patch)
2019-03-11 23:28 PDT, Ryosuke Niwa 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-03-11 23:28:18 PDT
Do it!
Ryosuke Niwa
Comment 2 2019-03-11 23:28:25 PDT
Created attachment 364355 [details] Cleanup
Brent Fulgham
Comment 3 2019-03-11 23:31:43 PDT
Comment on attachment 364355 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=364355&action=review Nice! I find all of this code removal to be cathartic! > Source/WebCore/ChangeLog:9 > + However, the issue has since been resolved as of OS X Mountain Lion, Weird white spacing on this line. > Source/WebCore/ChangeLog:13 > + the only scenario in which this quirk come into play is when a third party app “comes into play”
EWS Watchlist
Comment 4 2019-03-11 23:32:56 PDT
Attachment 364355 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 5 2019-03-11 23:49:32 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 364355 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364355&action=review > > Nice! I find all of this code removal to be cathartic! > > > Source/WebCore/ChangeLog:9 > > + However, the issue has since been resolved as of OS X Mountain Lion, > > Weird white spacing on this line. Fixed. > > Source/WebCore/ChangeLog:13 > > + the only scenario in which this quirk come into play is when a third party app > > “comes into play” Fixed.
Ryosuke Niwa
Comment 6 2019-03-11 23:55:47 PDT
For those at Apple, also see <rdar://problem/9489557>.
Ryosuke Niwa
Comment 7 2019-03-11 23:58:22 PDT
Committed r242784: <https://trac.webkit.org/changeset/242784>
Radar WebKit Bug Importer
Comment 8 2019-03-11 23:59:23 PDT
<rdar://problem/48799810>
Note You need to log in before you can comment on or make changes to this bug.