Bug 195591

Summary:

Web Inspector: ScriptProfiler: lazily create the agent

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

195865

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Patch	none

Devin Rousso

Reported 2019-03-11 17:53:35 PDT

Attachments
Patch (9.21 KB, patch) 2019-03-17 16:42 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (9.54 KB, patch) 2019-03-18 19:07 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.89 MB, application/zip) 2019-03-19 01:20 PDT, EWS Watchlist	no flags	Details
Patch (9.66 KB, patch) 2019-03-19 11:52 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-11 17:54:26 PDT

<rdar://problem/48791756>

Devin Rousso

Comment 2 2019-03-17 16:42:15 PDT

Created attachment 364985 [details] Patch

Devin Rousso

Comment 3 2019-03-18 19:07:35 PDT

Created attachment 365107 [details] Patch

Joseph Pecoraro

Comment 4 2019-03-18 21:54:41 PDT

Comment on attachment 365107 [details] Patch Nice, r=me

Yusuke Suzuki

Comment 5 2019-03-18 23:53:45 PDT

Cool!

EWS Watchlist

Comment 6 2019-03-19 01:20:44 PDT Comment hidden (obsolete)

Comment on attachment 365107 [details] Patch Attachment 365107 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11559838 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

EWS Watchlist

Comment 7 2019-03-19 01:20:46 PDT Comment hidden (obsolete)

Created attachment 365136 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

WebKit Commit Bot

Comment 8 2019-03-19 10:51:00 PDT Comment hidden (obsolete)

Comment on attachment 365107 [details] Patch Rejecting attachment 365107 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 365107, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365107&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=195591&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 365107 from bug 195591. Fetching: https://bugs.webkit.org/attachment.cgi?id=365107 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 6 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp patching file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.h patching file Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp Hunk #1 FAILED at 76. Hunk #2 succeeded at 315 with fuzz 2 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp.rej patching file Source/WebCore/inspector/InspectorController.cpp Hunk #1 FAILED at 135. Hunk #2 succeeded at 198 (offset -3 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorController.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11567894

Devin Rousso

Comment 9 2019-03-19 11:52:55 PDT

Created attachment 365196 [details] Patch

WebKit Commit Bot

Comment 10 2019-03-19 12:25:59 PDT

Comment on attachment 365196 [details] Patch Clearing flags on attachment: 365196 Committed r243160: <https://trac.webkit.org/changeset/243160>

WebKit Commit Bot

Comment 11 2019-03-19 12:26:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.