Bug 195444

Summary: [JSC] Remove merging must handle values into proven types in CFA
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Yusuke Suzuki
Reported 2019-03-07 17:49:10 PST
...
Attachments
Patch for landing (8.38 KB, patch)
2019-03-07 18:30 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-07 18:05:15 PST
I've changed the ChangeLog part since OSR entry validates the value with AbstractValue. We should not consume must handle value as a constant AbstractValue in CFA since we do not have strong assumption that must handle values should be the same constants when kicking off concurrent compilation and actually performing OSR entry.
Yusuke Suzuki
Comment 2 2019-03-07 18:30:16 PST
Created attachment 363969 [details] Patch for landing
Yusuke Suzuki
Comment 3 2019-03-07 18:31:18 PST
Originally, this patch is included in https://bugs.webkit.org/show_bug.cgi?id=195429, and separated after the review. (https://bugs.webkit.org/show_bug.cgi?id=195429#c4).
Yusuke Suzuki
Comment 4 2019-03-07 18:55:01 PST
Landed in https://trac.webkit.org/changeset/242627/webkit
Radar WebKit Bug Importer
Comment 5 2019-03-07 19:11:18 PST
<rdar://problem/48700174>
Note You need to log in before you can comment on or make changes to this bug.