| Summary: | [JSC] StringFromCharCode fast path should accept 0xff in DFG and FTL | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2019-03-07 13:29:52 PST
Created attachment 363925 [details]
Patch
Created attachment 363926 [details]
Patch
Comment on attachment 363926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review > Source/JavaScriptCore/ChangeLog:45 > + Since (1) this is just an optimization, (2) type information is already propagated in prediction injection phase, and (3) the must handle value does not show the performance We should make these separate bugs and patches. r=me on both. Comment on attachment 363926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:45 >> + Since (1) this is just an optimization, (2) type information is already propagated in prediction injection phase, and (3) the must handle value does not show the performance > > We should make these separate bugs and patches. r=me on both. OK, I'll soon upload the latter part in a separate patch. I've just moved must handle value part to https://bugs.webkit.org/show_bug.cgi?id=195444 Created attachment 363965 [details]
Patch for landing
Committed r242626: <https://trac.webkit.org/changeset/242626> |