Bug 195429

Summary: [JSC] StringFromCharCode fast path should accept 0xff in DFG and FTL
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
saam: review+
Patch for landing none

Yusuke Suzuki
Reported 2019-03-07 13:29:52 PST
[JSC] Remove merging must handle values into proven types in CFA
Attachments
Patch (12.50 KB, patch)
2019-03-07 14:05 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.88 KB, patch)
2019-03-07 14:14 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Patch for landing (4.81 KB, patch)
2019-03-07 17:52 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-07 14:05:26 PST
Created attachment 363925 [details] Patch
Mark Lam
Comment 2 2019-03-07 14:11:44 PST
<rdar://problem/48629581>
Yusuke Suzuki
Comment 3 2019-03-07 14:14:47 PST
Created attachment 363926 [details] Patch
Saam Barati
Comment 4 2019-03-07 17:36:08 PST
Comment on attachment 363926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review > Source/JavaScriptCore/ChangeLog:45 > + Since (1) this is just an optimization, (2) type information is already propagated in prediction injection phase, and (3) the must handle value does not show the performance We should make these separate bugs and patches. r=me on both.
Yusuke Suzuki
Comment 5 2019-03-07 17:36:45 PST
Comment on attachment 363926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:45 >> + Since (1) this is just an optimization, (2) type information is already propagated in prediction injection phase, and (3) the must handle value does not show the performance > > We should make these separate bugs and patches. r=me on both. OK, I'll soon upload the latter part in a separate patch.
Yusuke Suzuki
Comment 6 2019-03-07 17:49:49 PST
I've just moved must handle value part to https://bugs.webkit.org/show_bug.cgi?id=195444
Yusuke Suzuki
Comment 7 2019-03-07 17:52:43 PST
Created attachment 363965 [details] Patch for landing
Yusuke Suzuki
Comment 8 2019-03-07 17:53:41 PST
Committed r242626: <https://trac.webkit.org/changeset/242626>
Note You need to log in before you can comment on or make changes to this bug.