| Summary: | Fixed makeString(float) to do shortest-form serialization without first converting to double | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | Web Template Framework | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 178319 | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2019-02-27 20:20:42 PST
Created attachment 363189 [details]
Patch
Created attachment 363411 [details]
Patch
Passes tests, ready for review. Followups will reduce use of fixed precision and fixed width, which have been used to work around the lack of this. Comment on attachment 363411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363411&action=review This patch is ok as-is. I’m was torn during review between pointing out style issues in the dtoa code or not because its code we brought over. For the lines you touched we could go farther towards conforming to the guide > Source/WTF/ChangeLog:12 > + marked the constructor explicit, removed types used only fir arguments for fir > Source/WTF/wtf/dtoa.h:30 > +using DtoaBuffer = std::array<char, 80>; Nice. Committed r242316: <https://trac.webkit.org/changeset/242316> |