Summary: | Update double-conversion to the latest version | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> |
Component: | Web Template Framework | Assignee: | Sam Weinig <sam> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 178319 | ||
Attachments: |
Description
Sam Weinig
2019-02-24 12:55:18 PST
Created attachment 362860 [details]
Patch
This initial patch updates the library and applies most of the changes we have made to it over the years. One change it is still missing is the change to streamline strtod from https://bugs.webkit.org/show_bug.cgi?id=82857. It will have to be a bit different, due to added single precision float support, but not that different. I will finish that off before posting a final patch for review. Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11270244 Number of test failures exceeded the failure limit. Created attachment 362861 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11270249 Number of test failures exceeded the failure limit. Created attachment 362862 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11270243 Number of test failures exceeded the failure limit. Created attachment 362863 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11270398 Number of test failures exceeded the failure limit. Created attachment 362864 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 362865 [details]
Patch
Created attachment 362866 [details]
Patch
Created attachment 362870 [details]
Patch
Created attachment 362871 [details]
Diff showing just the changes made on top of the upstream version
Created attachment 362877 [details]
Patch
Created attachment 362878 [details]
Diff showing just the changes made on top of the upstream version
Created attachment 362879 [details]
Patch
Comment on attachment 362879 [details] Patch Attachment 362879 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11273571 New failing tests: fast/viewport/ios/device-width-viewport-after-changing-view-scale.html Created attachment 362885 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #18) > fast/viewport/ios/device-width-viewport-after-changing-view-scale.html This flaky test is causing spurious failures for me too when I am working on unrelated patches. Comment on attachment 362879 [details] Patch Clearing flags on attachment: 362879 Committed r242048: <https://trac.webkit.org/changeset/242048> All reviewed patches have been landed. Closing bug. |