| Summary: | Migrate from "fixedPositionRect" to "layoutViewport" in the scrolling tree | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, ews-watchlist, fred.wang, jamesr, koivisto, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 194973 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2019-02-23 18:30:14 PST
Created attachment 362843 [details]
Patch
Attachment 362843 [details] did not pass style-queue:
ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:45: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:57: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:58: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 3 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 362843 [details]
Patch
rs=me
Comment on attachment 362843 [details] Patch Clearing flags on attachment: 362843 Committed r242031: <https://trac.webkit.org/changeset/242031> All reviewed patches have been landed. Closing bug. |