Bug 194984

Summary: Migrate from "fixedPositionRect" to "layoutViewport" in the scrolling tree
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, ews-watchlist, fred.wang, jamesr, koivisto, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 194973    
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2019-02-23 18:30:14 PST
Migrate from "fixedPositionRect" to "layoutViewport" in the scrolling tree
Attachments
Patch (46.72 KB, patch)
2019-02-23 18:33 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-02-23 18:33:26 PST
Created attachment 362843 [details] Patch
EWS Watchlist
Comment 2 2019-02-23 18:35:49 PST
Attachment 362843 [details] did not pass style-queue: ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:45: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:57: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:58: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 3 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2019-02-23 18:52:22 PST
Comment on attachment 362843 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2019-02-24 22:03:28 PST
Comment on attachment 362843 [details] Patch Clearing flags on attachment: 362843 Committed r242031: <https://trac.webkit.org/changeset/242031>
WebKit Commit Bot
Comment 5 2019-02-24 22:03:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-02-24 22:09:37 PST
<rdar://problem/48353325>
Note You need to log in before you can comment on or make changes to this bug.