Summary: | Remove a "The " in "The The HTTP headers of the response" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | scootergrisen | ||||
Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Trivial | CC: | aperez, berto, bugs-noreply, cgarcia, clopez, commit-queue, ews-watchlist, gustavo, pnormand | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
scootergrisen
2019-02-20 01:26:21 PST
Created attachment 380474 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 380474 [details]
Patch
Updating all the translation po files isn't needed as well?
(In reply to Carlos Alberto Lopez Perez from comment #3) > Comment on attachment 380474 [details] > Patch > > Updating all the translation po files isn't needed as well? The template (.pot) translation file is generated automatically by CMake. AFAIU translators will pick that (and possibly merge it with the existing translations) next time they update the translatable strings, and each .po file will be updated when a translator sends up an updated copy later on. The commit-queue encountered the following flaky tests while processing attachment 380474 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 202799 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 380474 [details] Patch Clearing flags on attachment: 380474 Committed r250967: <https://trac.webkit.org/changeset/250967> All reviewed patches have been landed. Closing bug. |