| Summary: | [ews-app] status bubble should be hidden for certain builds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, dewei_zhu, kocsen_chung, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-02-13 10:43:24 PST
Created attachment 364484 [details]
Proposed patch
Comment on attachment 364484 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364484&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:88 > + if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string): Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think? > Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think? Agree. Since these values are already referenced in multiple places in this file, making that change in a separate patch in https://bugs.webkit.org/show_bug.cgi?id=195668 Committed r242880: <https://trac.webkit.org/changeset/242880> |