Bug 194597

Summary: [ews-app] status bubble should be hidden for certain builds
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch dewei_zhu: review+

Aakash Jain
Reported 2019-02-13 10:43:24 PST
While generating status bubbles (in ews-app) certain build should not generate status bubble. e.g.: builds which were skipped because patch was not relevant to that queue (e.g: non-webkitpy change skipping webkitpy ews queue).
Attachments
Proposed patch (2.74 KB, patch)
2019-03-12 17:42 PDT, Aakash Jain 		dewei_zhu: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-12 17:42:43 PDT
Created attachment 364484 [details] Proposed patch
dewei_zhu
Comment 2 2019-03-13 00:10:39 PDT
Comment on attachment 364484 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364484&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:88 > + if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string): Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think?
Aakash Jain
Comment 3 2019-03-13 04:26:27 PDT
> Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think? Agree. Since these values are already referenced in multiple places in this file, making that change in a separate patch in https://bugs.webkit.org/show_bug.cgi?id=195668
Aakash Jain
Comment 4 2019-03-13 04:27:54 PDT
Committed r242880: <https://trac.webkit.org/changeset/242880>
Radar WebKit Bug Importer
Comment 5 2019-03-13 04:28:19 PDT
<rdar://problem/48843642>
Note You need to log in before you can comment on or make changes to this bug.