Bug 194553

Summary: [WPE][GTK][STABLE] Remove sandbox APIs from 2.24 branch
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro, pgriffis
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194274
Attachments:
Description Flags
Patch
none
Patch cgarcia: review+, mcatanzaro: commit-queue-

Michael Catanzaro
Reported 2019-02-12 12:54:06 PST
Remove the sandbox APIs from the 2.24 branch, since they haven't received enough testing yet. My patch in bug #194274 upgrades the Since tags to 2.26, for trunk.
Attachments
Patch (9.62 KB, patch)
2019-02-12 12:55 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (57.99 KB, patch)
2019-02-13 10:47 PST, Michael Catanzaro 		cgarcia: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-02-12 12:55:01 PST
Created attachment 361824 [details] Patch
Carlos Garcia Campos
Comment 2 2019-02-12 23:32:15 PST
Comment on attachment 361824 [details] Patch Not only the APIs, we should remove the implementation as well, we don't want dead code in the stable branch
Michael Catanzaro
Comment 3 2019-02-13 08:37:46 PST
I think all the code is guarded by ENABLE(BUBBLEWRAP_SANDBOX), so it should not be built. I can remove it all if you want, but there's probably no benefit, and there's a small cost in making backports harder.
Carlos Garcia Campos
Comment 4 2019-02-13 09:01:57 PST
(In reply to Michael Catanzaro from comment #3) > I think all the code is guarded by ENABLE(BUBBLEWRAP_SANDBOX), so it should > not be built. I can remove it all if you want, but there's probably no > benefit, and there's a small cost in making backports harder. We are not going to backport any sandbox fix anyway.
Michael Catanzaro
Comment 5 2019-02-13 10:47:25 PST
Created attachment 361925 [details] Patch
Carlos Garcia Campos
Comment 6 2019-02-14 03:31:28 PST
Committed r241540: <https://trac.webkit.org/changeset/241540>
Note You need to log in before you can comment on or make changes to this bug.