Bug 194368 – REGRESSION (r240727) [ Mac iOS ] Layout Test http/tests/workers/service/basic-register-exceptions.html is flaky

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Shawn Roberts]

The following layout test is flaky on Mac and iOS

http/tests/workers/service/basic-register-exceptions.html

Probable cause:

Test became a regression after 240727

Reproduced with:

run-webkit-tests d240727 http/tests/workers/service/basic-register-exceptions.html --iterations 5000 -f --exit-after-n-failures=1 --no-retry-failures --debug

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-register-exceptions.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-register-exceptions-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-register-exceptions-actual.txt
@@ -5,5 +5,6 @@
 CONSOLE MESSAGE: line 60: Registration failed with error: TypeError: Scope URL provided to serviceWorker.register() must be either HTTP or HTTPS
 CONSOLE MESSAGE: line 70: Registration failed with error: TypeError: Scope URL provided to serviceWorker.register() cannot have a path that contains '%2f' or '%5c'
 CONSOLE MESSAGE: line 80: Registration failed with error: SecurityError: Script origin does not match the registering client's origin
+CONSOLE MESSAGE: line 10: Registration failed with error: TypeError: Script load failed
 CONSOLE MESSAGE: line 91: Registration failed with error: SecurityError: Scope origin does not match the registering client's origin

[Radar WebKit Bug Importer]

<rdar://problem/47937467>

[Shawn Roberts]

Created attachment 362505 [details]
Updating TestExpectations

[WebKit Commit Bot]

Comment on attachment 362505 [details]
Updating TestExpectations

Clearing flags on attachment: 362505

Committed r241819: <https://trac.webkit.org/changeset/241819>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shawn Roberts]

Reopened until fix is landed.

[Shawn Roberts]

Additional repro information. 

Test appears to only fail locally when I run it in full parallel, or when running with other tests. 

Example :

Had one window run-webkit-tests --child-processes 4 --debug --force

Another window run-webkit-tests http/tests/workers/service/basic-register-exceptions.html --iterations 1000 --child-processes 1 --force --debug

The test would fail.

When I run the test by itself with only 1 child process I am unable to reproduce it locally.

[youenn fablet]

I do not think this is a regression, it is just that the test is flaky by nature.
I'll fix it.

[youenn fablet]

Created attachment 367969 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367969 [details]
Patch

Clearing flags on attachment: 367969

Committed r244539: <https://trac.webkit.org/changeset/244539>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.