Bug 193956

Summary: REGRESSION (r240358): IndexedDB/large-binary-keys.html and IndexedDB/large-string-keys.html perf tests failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, ews-watchlist, ggaren, jlewis3, rniwa, sihui_liu, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192796
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2 none

Ryan Haddad
Reported 2019-01-28 22:06:06 PST
IndexedDB/large-binary-keys.html and IndexedDB/large-string-keys.html perf tests are failing, as seen here: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Perf%29/builds/135 Running IndexedDB/large-binary-keys.html (79 of 185) timeout: IndexedDB/large-binary-keys.html FAILED Finished: 605.025108 s Running IndexedDB/large-string-keys.html (82 of 185) timeout: IndexedDB/large-string-keys.html FAILED Finished: 605.021979 s This regressed between r240348 and r240361.
Attachments
Patch (2.13 KB, patch)
2019-01-30 18:35 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.46 MB, application/zip)
2019-01-30 20:46 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2019-01-28 22:07:31 PST
This is probably related to: "Clean up IndexedDB files between tests" https://trac.webkit.org/changeset/240358/webkit
Radar WebKit Bug Importer
Comment 2 2019-01-28 22:07:49 PST
<rdar://problem/47623109>
Sihui Liu
Comment 3 2019-01-30 18:35:32 PST
Created attachment 360666 [details] Patch
EWS Watchlist
Comment 4 2019-01-30 20:46:55 PST
Comment on attachment 360666 [details] Patch Attachment 360666 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10963066 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
EWS Watchlist
Comment 5 2019-01-30 20:46:57 PST
Created attachment 360685 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Ryosuke Niwa
Comment 6 2019-01-30 23:37:31 PST
Comment on attachment 360666 [details] Patch There is no way this could have caused the iOS test failure because this patch simply fixes the failing performance tests.
WebKit Commit Bot
Comment 7 2019-01-31 00:06:22 PST
Comment on attachment 360666 [details] Patch Clearing flags on attachment: 360666 Committed r240767: <https://trac.webkit.org/changeset/240767>
WebKit Commit Bot
Comment 8 2019-01-31 00:06:24 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 9 2019-01-31 17:12:14 PST
The tests are passing now.
Note You need to log in before you can comment on or make changes to this bug.