Bug 193729

Summary: [ews-app] Rename ews model buildermappings to buildermapping
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193697
Attachments:
Description Flags
Proposed patch lforschler: review+

Description Aakash Jain 2019-01-23 10:38:01 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'buildermappings' to 'buildermapping' in ews-app model.
Comment 1 Aakash Jain 2019-01-23 11:16:54 PST
Created attachment 359907 [details]
Proposed patch
Comment 2 Kocsen Chung 2019-01-23 11:19:27 PST
Comment on attachment 359907 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:28
> +class BuilderMappings(models.Model):

Should this be singular BuilderMapping ?
Comment 3 Kocsen Chung 2019-01-23 11:20:42 PST
R+; looks good to me.
Comment 4 Lucas Forschler 2019-01-23 13:17:50 PST
Comment on attachment 359907 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:1
> +# Copyright (C) 2018 Apple Inc. All rights reserved.

maybe update this to 2019?
Comment 5 Aakash Jain 2019-01-23 13:59:16 PST
Committed r240361: <https://trac.webkit.org/changeset/240361>
Comment 6 Radar WebKit Bug Importer 2019-01-23 14:00:32 PST
<rdar://problem/47492954>