Summary: | [ews-app] Rename ews model buildermappings to buildermapping | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=193697 | ||||||
Attachments: |
|
Description
Aakash Jain
2019-01-23 10:38:01 PST
Created attachment 359907 [details]
Proposed patch
Comment on attachment 359907 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:28 > +class BuilderMappings(models.Model): Should this be singular BuilderMapping ? R+; looks good to me. Comment on attachment 359907 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:1 > +# Copyright (C) 2018 Apple Inc. All rights reserved. maybe update this to 2019? Committed r240361: <https://trac.webkit.org/changeset/240361> |