Bug 193695

Summary: [ews-app] Rename ews model Builds to Build
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193697
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Aakash Jain
Reported 2019-01-22 16:04:46 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'Builds' to 'Build' in ews-app model.
Attachments
Proposed patch (2.86 KB, patch)
2019-01-22 17:04 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Proposed patch (3.33 KB, patch)
2019-01-23 11:18 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-22 17:04:01 PST
Created attachment 359812 [details] Proposed patch
Aakash Jain
Comment 2 2019-01-23 11:18:01 PST
Created attachment 359908 [details] Proposed patch
Kocsen Chung
Comment 3 2019-01-23 11:20:30 PST
r+; looks good to me.
WebKit Commit Bot
Comment 4 2019-01-23 13:37:35 PST
Comment on attachment 359908 [details] Proposed patch Clearing flags on attachment: 359908 Committed r240357: <https://trac.webkit.org/changeset/240357>
WebKit Commit Bot
Comment 5 2019-01-23 13:37:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-23 13:38:48 PST
<rdar://problem/47492092>
Note You need to log in before you can comment on or make changes to this bug.