Summary: | [build.webkit.org] Unit-test failure after r237113 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, lforschler, mcatanzaro, pnormand, ryanhaddad, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=190581 | ||||||||||
Attachments: |
|
Description
Aakash Jain
2019-01-22 06:58:40 PST
Created attachment 359734 [details]
Unit-test fix
Comment on attachment 359734 [details] Unit-test fix Since this is not the expected result, could we please do the fix you proposed in bug #190581 instead: """ If this step is not expected, factories.py L42 should be changed to something like: if platform == "gtk" and "--no-experimental-features" not in additionalArguments: """ Created attachment 359742 [details]
Proposed patch
Updated factories.py L42 appropriately. Also took care of the case when 'additionalArguments' is None.
Unit-tests pass after this change.
Comment on attachment 359742 [details] Proposed patch Attachment 359742 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10840564 New failing tests: compositing/backing/animate-into-view.html Created attachment 359752 [details]
Archive of layout-test-results from ews115 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 359742 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359742&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:42 > - if platform == "gtk" and additionalArguments != ["--no-experimental-features"]: > + if platform == "gtk" and "--no-experimental-features" not in (additionalArguments or []): Why do you need the "or []"? > Why do you need the "or []"?
since additionalArguments can be None.
Comment on attachment 359742 [details] Proposed patch Clearing flags on attachment: 359742 Committed r240291: <https://trac.webkit.org/changeset/240291> All reviewed patches have been landed. Closing bug. *** Bug 191318 has been marked as a duplicate of this bug. *** |