Bug 193669 – [build.webkit.org] Unit-test failure after r237113

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

2 unit-tests are failing. It seems to be since https://trac.webkit.org/changeset/237113/webkit

-bash-4.2$ ./steps_unittest.py
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................FF....................................................

======================================================================
FAIL: test_builder GTK Linux 64-bit Release Debian Stable (Build) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 591, in doTest
    self.assertListEqual(expected_build_steps[builder['name']], buildSteps)
AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki...

First differing element 5:
compile-webkit
jhbuild

Second list contains 1 additional elements.
First extra element 6:
compile-webkit

  ['configure build',
   'svn',
   'kill old processes',
   'delete WebKitBuild directory',
   'delete stale build files',
+  'jhbuild',
   'compile-webkit']

======================================================================
FAIL: test_builder GTK Linux 64-bit Release Ubuntu LTS (Build) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 591, in doTest
    self.assertListEqual(expected_build_steps[builder['name']], buildSteps)
AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki...

First differing element 5:
compile-webkit
jhbuild

Second list contains 1 additional elements.
First extra element 6:
compile-webkit

  ['configure build',
   'svn',
   'kill old processes',
   'delete WebKitBuild directory',
   'delete stale build files',
+  'jhbuild',
   'compile-webkit']

----------------------------------------------------------------------
Ran 764 tests in 0.395s

FAILED (failures=2)

[Aakash Jain]

Created attachment 359734 [details]
Unit-test fix

[Michael Catanzaro]

Comment on attachment 359734 [details]
Unit-test fix

Since this is not the expected result, could we please do the fix you proposed in bug #190581 instead:

"""
If this step is not expected, factories.py L42 should be changed to something like:

    if platform == "gtk" and "--no-experimental-features" not in additionalArguments:
"""

[Aakash Jain]

Created attachment 359742 [details]
Proposed patch

Updated factories.py L42 appropriately. Also took care of the case when 'additionalArguments' is None.

Unit-tests pass after this change.

[EWS Watchlist]

Comment on attachment 359742 [details]
Proposed patch

Attachment 359742 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10840564

New failing tests:
compositing/backing/animate-into-view.html

[EWS Watchlist]

Created attachment 359752 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Michael Catanzaro]

Comment on attachment 359742 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359742&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:42
> -        if platform == "gtk" and additionalArguments != ["--no-experimental-features"]:
> +        if platform == "gtk" and "--no-experimental-features" not in (additionalArguments or []):

Why do you need the "or []"?

[Aakash Jain]

> Why do you need the "or []"?

since additionalArguments can be None.

[WebKit Commit Bot]

Comment on attachment 359742 [details]
Proposed patch

Clearing flags on attachment: 359742

Committed r240291: <https://trac.webkit.org/changeset/240291>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47457588>

[Ryan Haddad]

*** Bug 191318 has been marked as a duplicate of this bug. ***