Bug 193478

Summary: [Mac] Add a new quirk to HTMLFormControlElement::isMouseFocusable
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: FormsAssignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, karlcow, rniwa, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=311383
Bug Depends on:    
Bug Blocks: 267569, 276709, 296989, 311383    
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2019-01-15 18:22:56 PST
Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. This quirk is for ceac.state.gov specifically.
Attachments
Patch (3.03 KB, patch)
2019-01-15 18:31 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (3.55 KB, patch)
2019-01-16 11:58 PST, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (3.63 KB, patch)
2019-01-17 11:08 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2019-01-15 18:24:44 PST
<rdar://problem/34368591>
Jiewen Tan
Comment 2 2019-01-15 18:31:21 PST
Created attachment 359238 [details] Patch
Jiewen Tan
Comment 3 2019-01-15 18:32:45 PST
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:661 > + The new line should be deleted.
Chris Dumez
Comment 4 2019-01-15 19:19:33 PST
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:662 > +bool HTMLFormControlElement::needsSiteSpecificQuirks() const The name should say what the quirk is about. What if we had more than one quirk?
Chris Dumez
Comment 5 2019-01-15 19:19:36 PST
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:662 > +bool HTMLFormControlElement::needsSiteSpecificQuirks() const The name should say what the quirk is about. What if we had more than one quirk?
Chris Dumez
Comment 6 2019-01-15 19:34:19 PST
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/ChangeLog:9 > + Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. Could you explain in the changelog why we do this behavior only for this site and not all sites? How do other browsers behave? >>> Source/WebCore/html/HTMLFormControlElement.cpp:662 >>> +bool HTMLFormControlElement::needsSiteSpecificQuirks() const >> >> The name should say what the quirk is about. What if we had more than one quirk? > > The name should say what the quirk is about. What if we had more than one quirk? E.g. needsMouseFocusableQuirk()
Jiewen Tan
Comment 7 2019-01-16 11:55:12 PST
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review Thanks Chris for reviewing the patch. >> Source/WebCore/ChangeLog:9 >> + Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. > > Could you explain in the changelog why we do this behavior only for this site and not all sites? How do other browsers behave? Sure, improved. >>>> Source/WebCore/html/HTMLFormControlElement.cpp:662 >>>> +bool HTMLFormControlElement::needsSiteSpecificQuirks() const >>> >>> The name should say what the quirk is about. What if we had more than one quirk? >> >> The name should say what the quirk is about. What if we had more than one quirk? > > E.g. needsMouseFocusableQuirk() Hopefully not. Fixed.
Jiewen Tan
Comment 8 2019-01-16 11:58:50 PST
Created attachment 359287 [details] Patch
Jiewen Tan
Comment 9 2019-01-16 16:47:56 PST
Comment on attachment 359287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359287&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:660 > Added: // FIXME: We should remove the quirk once <rdar://problem/47334655> is fixed.
Brent Fulgham
Comment 10 2019-01-16 19:48:26 PST
Comment on attachment 359287 [details] Patch Thanks!
Jiewen Tan
Comment 11 2019-01-17 11:08:30 PST
Created attachment 359392 [details] Patch for landing
Jiewen Tan
Comment 12 2019-01-17 11:08:54 PST
(In reply to Brent Fulgham from comment #10) > Comment on attachment 359287 [details] > Patch > > Thanks! Thanks for r+ it.
WebKit Commit Bot
Comment 13 2019-01-17 11:34:34 PST
Comment on attachment 359392 [details] Patch for landing Clearing flags on attachment: 359392 Committed r240122: <https://trac.webkit.org/changeset/240122>
Karl Dubost
Comment 14 2024-01-16 23:59:30 PST
*** Bug 267449 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.