Bug 193333

Summary: WebDriver: update Create Browsing Context implementation to support newest specification
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebKit APIAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, hi, joepeck, mcatanzaro, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
For Landing none

Description BJ Burg 2019-01-10 13:27:19 PST
.
Comment 1 BJ Burg 2019-01-10 13:27:33 PST
<rdar://problem/45649489>
Comment 2 BJ Burg 2019-01-10 14:11:44 PST
Created attachment 358833 [details]
Patch
Comment 3 BJ Burg 2019-01-10 14:31:47 PST
Patch depends on https://bugs.webkit.org/show_bug.cgi?id=193331. I will tickle EWS once that lands via cq.
Comment 4 BJ Burg 2019-01-10 14:40:38 PST
Created attachment 358837 [details]
Patch
Comment 5 Carlos Garcia Campos 2019-01-11 00:49:33 PST
Comment on attachment 358837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358837&action=review

This looks good to me. An apple reviewer might want to check the new API, though.

> Source/WebKit/UIProcess/Automation/Automation.json:335
>                  { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."}

Should we change this now too? Using the enum too and renamed as presentationHint.
Comment 6 BJ Burg 2019-01-11 10:57:04 PST
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 358837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358837&action=review
> 
> This looks good to me. An apple reviewer might want to check the new API,
> though.
> 
> > Source/WebKit/UIProcess/Automation/Automation.json:335
> >                  { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."}
> 
> Should we change this now too? Using the enum too and renamed as
> presentationHint.

Sure, we can do that.
Comment 7 BJ Burg 2019-01-11 11:44:24 PST
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 358837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358837&action=review
> 
> This looks good to me. An apple reviewer might want to check the new API,
> though.

Since I posted the patch, Wenson took a look and was okay with the changes.
Comment 8 BJ Burg 2019-01-11 11:45:27 PST
Created attachment 358920 [details]
For Landing
Comment 9 BJ Burg 2019-01-15 09:15:50 PST
Committed r239988: <https://trac.webkit.org/changeset/239988>
Comment 10 Michael Catanzaro 2019-01-20 21:09:40 PST
Committed r240226: <https://trac.webkit.org/changeset/240226>