Bug 193333

Summary: WebDriver: update Create Browsing Context implementation to support newest specification
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKit APIAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, hi, joepeck, mcatanzaro, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
For Landing none

Blaze Burg
Reported 2019-01-10 13:27:19 PST
.
Attachments
Patch (12.71 KB, patch)
2019-01-10 14:11 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (12.71 KB, patch)
2019-01-10 14:40 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For Landing (15.13 KB, patch)
2019-01-11 11:45 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2019-01-10 13:27:33 PST
<rdar://problem/45649489>
Blaze Burg
Comment 2 2019-01-10 14:11:44 PST
Created attachment 358833 [details] Patch
Blaze Burg
Comment 3 2019-01-10 14:31:47 PST
Patch depends on https://bugs.webkit.org/show_bug.cgi?id=193331. I will tickle EWS once that lands via cq.
Blaze Burg
Comment 4 2019-01-10 14:40:38 PST
Created attachment 358837 [details] Patch
Carlos Garcia Campos
Comment 5 2019-01-11 00:49:33 PST
Comment on attachment 358837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358837&action=review This looks good to me. An apple reviewer might want to check the new API, though. > Source/WebKit/UIProcess/Automation/Automation.json:335 > { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."} Should we change this now too? Using the enum too and renamed as presentationHint.
Blaze Burg
Comment 6 2019-01-11 10:57:04 PST
(In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 358837 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358837&action=review > > This looks good to me. An apple reviewer might want to check the new API, > though. > > > Source/WebKit/UIProcess/Automation/Automation.json:335 > > { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."} > > Should we change this now too? Using the enum too and renamed as > presentationHint. Sure, we can do that.
Blaze Burg
Comment 7 2019-01-11 11:44:24 PST
(In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 358837 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358837&action=review > > This looks good to me. An apple reviewer might want to check the new API, > though. Since I posted the patch, Wenson took a look and was okay with the changes.
Blaze Burg
Comment 8 2019-01-11 11:45:27 PST
Created attachment 358920 [details] For Landing
Blaze Burg
Comment 9 2019-01-15 09:15:50 PST
Committed r239988: <https://trac.webkit.org/changeset/239988>
Michael Catanzaro
Comment 10 2019-01-20 21:09:40 PST
Committed r240226: <https://trac.webkit.org/changeset/240226>
Note You need to log in before you can comment on or make changes to this bug.