Summary: | WebDriver: update Create Browsing Context implementation to support newest specification | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
Component: | WebKit API | Assignee: | BJ Burg <bburg> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, cgarcia, hi, joepeck, mcatanzaro, thorton, timothy, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
BJ Burg
2019-01-10 13:27:19 PST
Created attachment 358833 [details]
Patch
Patch depends on https://bugs.webkit.org/show_bug.cgi?id=193331. I will tickle EWS once that lands via cq. Created attachment 358837 [details]
Patch
Comment on attachment 358837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358837&action=review This looks good to me. An apple reviewer might want to check the new API, though. > Source/WebKit/UIProcess/Automation/Automation.json:335 > { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."} Should we change this now too? Using the enum too and renamed as presentationHint. (In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 358837 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358837&action=review > > This looks good to me. An apple reviewer might want to check the new API, > though. > > > Source/WebKit/UIProcess/Automation/Automation.json:335 > > { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."} > > Should we change this now too? Using the enum too and renamed as > presentationHint. Sure, we can do that. (In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 358837 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358837&action=review > > This looks good to me. An apple reviewer might want to check the new API, > though. Since I posted the patch, Wenson took a look and was okay with the changes. Created attachment 358920 [details]
For Landing
Committed r239988: <https://trac.webkit.org/changeset/239988> Committed r240226: <https://trac.webkit.org/changeset/240226> |