Bug 193328

Summary: Bindings generator emits incorrect code when using VoidCallback as an IDL dictionary attribute
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: BindingsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, esprehn+autocc, ews-watchlist, kondapallykalyan, rniwa, thorton, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193109    
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2019-01-10 11:21:57 PST
For instance, this IDL: dictionary Foo { required VoidCallback bar; }; ...generates this code in the corresponding implementation of convertDictionary: if (!barValue.isUndefined()) { result.bar = convert<IDLCallbackFunction<JSVoidCallback>>(state, barValue, ); RETURN_IF_EXCEPTION(throwScope, { }); } else { throwRequiredMemberTypeError(state, throwScope, "bar", "FooInit", "VoidCallback"); return { }; } ...which (of course) fails to compile.
Attachments
Patch (5.01 KB, patch)
2019-01-10 12:01 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-01-10 12:01:40 PST
Created attachment 358816 [details] Patch
WebKit Commit Bot
Comment 2 2019-01-10 13:46:39 PST
Comment on attachment 358816 [details] Patch Clearing flags on attachment: 358816 Committed r239842: <https://trac.webkit.org/changeset/239842>
WebKit Commit Bot
Comment 3 2019-01-10 13:46:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-01-10 13:47:29 PST
<rdar://problem/47189164>
Note You need to log in before you can comment on or make changes to this bug.