Bug 193249

Summary: Web Inspector: Event breakpoints: text field and completion popover fonts should match
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch none

Nikita Vasilyev
Reported 2019-01-08 12:23:32 PST
Created attachment 358620 [details] [Image] Bug font-family and font-size should match. I suggest using "Menlo, monospace" as we always do for editable code. The completion popover text should be directly under the text field text — not shifted a few pixels on the left.
Attachments
[Image] Bug (40.03 KB, image/png)
2019-01-08 12:23 PST, Nikita Vasilyev 		no flags
Details
Patch (4.52 KB, patch)
2019-01-08 13:22 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-08 13:22:37 PST
Created attachment 358628 [details] Patch
Nikita Vasilyev
Comment 2 2019-01-08 14:27:22 PST
Comment on attachment 358628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review Works as expected. I'd r+. > Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css:42 > + font-family: system-ui; Interesting, we've never used "system-ui" before. I had to look it up when we added this: https://bugs.webkit.org/show_bug.cgi?id=151493. It seems like we can replace "-webkit-system-font" with "system-ui" everywhere. > Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199 > + rect.size.width -= padding + parseInt(computedStyle.borderRightWidth) + parseInt(computedStyle.paddingRight); `rect.size.width` doesn't seem to be used by this._suggestionsView.show.
Matt Baker
Comment 3 2019-01-14 14:26:53 PST
Comment on attachment 358628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review r=me >> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199 >> + rect.size.width -= padding + parseInt(computedStyle.borderRightWidth) + parseInt(computedStyle.paddingRight); > > `rect.size.width` doesn't seem to be used by this._suggestionsView.show. This is an implementation detail; we could change the signature if we really wanted: show(anchorOrigin, anchorHeight) or just show(origin, anchorHeight)
WebKit Commit Bot
Comment 4 2019-01-14 14:52:37 PST
Comment on attachment 358628 [details] Patch Clearing flags on attachment: 358628 Committed r239953: <https://trac.webkit.org/changeset/239953>
WebKit Commit Bot
Comment 5 2019-01-14 14:52:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-14 14:53:42 PST
<rdar://problem/47266828>
Note You need to log in before you can comment on or make changes to this bug.