| Summary: | Web Inspector: Event breakpoints: text field and completion popover fonts should match | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 358628 [details]
Patch
Comment on attachment 358628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review Works as expected. I'd r+. > Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css:42 > + font-family: system-ui; Interesting, we've never used "system-ui" before. I had to look it up when we added this: https://bugs.webkit.org/show_bug.cgi?id=151493. It seems like we can replace "-webkit-system-font" with "system-ui" everywhere. > Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199 > + rect.size.width -= padding + parseInt(computedStyle.borderRightWidth) + parseInt(computedStyle.paddingRight); `rect.size.width` doesn't seem to be used by this._suggestionsView.show. Comment on attachment 358628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review r=me >> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199 >> + rect.size.width -= padding + parseInt(computedStyle.borderRightWidth) + parseInt(computedStyle.paddingRight); > > `rect.size.width` doesn't seem to be used by this._suggestionsView.show. This is an implementation detail; we could change the signature if we really wanted: show(anchorOrigin, anchorHeight) or just show(origin, anchorHeight) Comment on attachment 358628 [details] Patch Clearing flags on attachment: 358628 Committed r239953: <https://trac.webkit.org/changeset/239953> All reviewed patches have been landed. Closing bug. |
Created attachment 358620 [details] [Image] Bug font-family and font-size should match. I suggest using "Menlo, monospace" as we always do for editable code. The completion popover text should be directly under the text field text — not shifted a few pixels on the left.