Bug 193141

Summary: webkitpy: Increase simulator teardown timeout
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-01-04 08:35:02 PST
We have a number of bots which are hitting the default 60 second timeout in SimulatedDeviceManager.tear_down. This is likely because that timeout is a collective timeout as opposed to a per-simulator timeout. Speculatively, I'd like to increase that timeout.
Attachments
Patch (1.43 KB, patch)
2019-01-04 08:42 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.44 KB, patch)
2019-01-04 09:08 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-01-04 08:37:13 PST
<rdar://problem/46174217>
Jonathan Bedard
Comment 2 2019-01-04 08:42:08 PST
Created attachment 358320 [details] Patch
Aakash Jain
Comment 3 2019-01-04 08:57:53 PST
rs=me
Jonathan Bedard
Comment 4 2019-01-04 09:08:42 PST
Created attachment 358323 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-01-04 09:57:27 PST
The commit-queue encountered the following flaky tests while processing attachment 358323 [details]: http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-01-04 09:58:17 PST
Comment on attachment 358323 [details] Patch for landing Clearing flags on attachment: 358323 Committed r239614: <https://trac.webkit.org/changeset/239614>
WebKit Commit Bot
Comment 7 2019-01-04 09:58:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-01-04 09:59:32 PST
<rdar://problem/47050278>
Note You need to log in before you can comment on or make changes to this bug.