Bug 193141 - webkitpy: Increase simulator teardown timeout
Summary: webkitpy: Increase simulator teardown timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-04 08:35 PST by Jonathan Bedard
Modified: 2019-01-04 09:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2019-01-04 08:42 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.44 KB, patch)
2019-01-04 09:08 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-01-04 08:35:02 PST 
We have a number of bots which are hitting the default 60 second timeout in SimulatedDeviceManager.tear_down. This is likely because that timeout is a collective timeout as opposed to a per-simulator timeout. Speculatively, I'd like to increase that timeout.
Comment 1 Jonathan Bedard 2019-01-04 08:37:13 PST 
<rdar://problem/46174217>
Comment 2 Jonathan Bedard 2019-01-04 08:42:08 PST 
Created attachment 358320 [details]
Patch
Comment 3 Aakash Jain 2019-01-04 08:57:53 PST 
rs=me
Comment 4 Jonathan Bedard 2019-01-04 09:08:42 PST 
Created attachment 358323 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-01-04 09:57:27 PST 
The commit-queue encountered the following flaky tests while processing attachment 358323 [details]:

http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2019-01-04 09:58:17 PST 
Comment on attachment 358323 [details]
Patch for landing

Clearing flags on attachment: 358323

Committed r239614: <https://trac.webkit.org/changeset/239614>
Comment 7 WebKit Commit Bot 2019-01-04 09:58:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-01-04 09:59:32 PST 
<rdar://problem/47050278>