Bug 193025

Summary: REGRESSION (r237269): webkit-patch what-broke is broken
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dean_johnson, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P1 Keywords: InRadar, Regression
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 190732    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2018-12-24 18:25:35 PST
webkit-patch what-broke is broken following <https://trac.webkit.org/changeset/237269/> (bug #190732). $ Tools/Scripts/webkit-patch what-broke Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 84, in <module> main() File "Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queries.py", line 212, in execute builder_statuses = tool.buildbot.builder_statuses() AttributeError: 'WebKitPatch' object has no attribute 'buildbot'
Attachments
Patch (1.14 KB, patch)
2019-02-01 16:13 PST, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2019-02-01 17:17 PST, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-28 17:37:29 PST
<rdar://problem/46974154>
WebKit Commit Bot
Comment 2 2019-02-01 16:13:23 PST
Created attachment 360921 [details] Patch
Daniel Bates
Comment 3 2019-02-01 16:44:59 PST
Comment on attachment 360921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360921&action=review > Tools/ChangeLog:1 > +2019-02-01 Commit Queue <commit-queue@webkit.org> It happened! AI is here! And I thought you were only capable of landing patches.
WebKit Commit Bot
Comment 4 2019-02-01 17:17:23 PST
Created attachment 360925 [details] Patch
Aakash Jain
Comment 5 2019-02-04 11:09:08 PST
r+ after fixing the ChangeLog.
WebKit Commit Bot
Comment 6 2019-02-04 11:49:14 PST
Comment on attachment 360925 [details] Patch Clearing flags on attachment: 360925 Committed r240936: <https://trac.webkit.org/changeset/240936>
WebKit Commit Bot
Comment 7 2019-02-04 11:49:16 PST
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 8 2019-02-04 21:16:20 PST
(In reply to WebKit Commit Bot from comment #4) > Created attachment 360925 [details] > Patch You're a bad bot. Now, you're impersonating someone else :/
Daniel Bates
Comment 9 2019-02-04 21:18:46 PST
(In reply to Daniel Bates from comment #8) > (In reply to WebKit Commit Bot from comment #4) > > Created attachment 360925 [details] > > Patch > > You're a bad bot. Now, you're impersonating someone else :/ Joking aside. Dean, hint, hint, hint.
Note You need to log in before you can comment on or make changes to this bug.