Bug 193024

Summary: [lldb-webkit]: Add support for pretty-printing raw bitmask types
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, dino, jer.noble, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193023
Attachments:
Description Flags
Patch
none
To Land none

Daniel Bates
Reported 2018-12-24 16:43:14 PST
There are some types, like WebEventFlags, that must remain a plain-old enumeration as opposed to being turned into an OptionSet. We should support pretty printing such types.
Attachments
Patch (10.36 KB, patch)
2018-12-24 17:02 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (9.42 KB, patch)
2019-01-04 11:21 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-12-24 17:02:10 PST
Created attachment 358050 [details] Patch
Daniel Bates
Comment 2 2018-12-24 17:05:02 PST
Note that the proposed patch (attachment #358050 [details]) includes the patch for bug #193023. I am hoping that people do not disagree with the fix for bug #193023. If they do, then I will fix up this patch as applicable.
Jer Noble
Comment 3 2019-01-04 10:02:30 PST
Comment on attachment 358050 [details] Patch 👍🏻
Daniel Bates
Comment 4 2019-01-04 11:21:20 PST
Created attachment 358341 [details] To Land
Daniel Bates
Comment 5 2019-01-04 21:03:37 PST
Committed r239651: <https://trac.webkit.org/changeset/239651>
Radar WebKit Bug Importer
Comment 6 2019-01-04 21:08:29 PST
<rdar://problem/47064007>
Note You need to log in before you can comment on or make changes to this bug.