Bug 192898

Summary: [iOS] uiController.keyDown() does not translate Control modified key
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, lforschler, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192897
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch and layout tests
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch and layout tests none

Description Daniel Bates 2018-12-19 16:39:50 PST
Key translation occurs with respect to the current keyboard layout when holding the Control key down and pressing a key. We need a way to do something similar so that we can use UIController.keyDown() to emulate Control modified key commands, such as Control + A.

On a related note, we may want to consider exposing a way to specify a particular keyboard layout to use when running a test to ensure consistent results regardless of the current keyboard layout.
Comment 1 Daniel Bates 2019-01-14 14:30:13 PST
Created attachment 359080 [details]
Patch
Comment 2 EWS Watchlist 2019-01-14 16:24:20 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2019-01-14 16:24:22 PST Comment hidden (obsolete)
Comment 4 Daniel Bates 2019-01-15 10:40:22 PST
Created attachment 359178 [details]
Patch and layout tests
Comment 5 EWS Watchlist 2019-01-15 12:26:44 PST Comment hidden (obsolete)
Comment 6 EWS Watchlist 2019-01-15 12:26:46 PST Comment hidden (obsolete)
Comment 7 Daniel Bates 2019-01-24 12:02:47 PST
Created attachment 360024 [details]
Patch and layout tests
Comment 8 Wenson Hsieh 2019-01-24 15:07:36 PST
Comment on attachment 360024 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=360024&action=review

> LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible-expected.html:7
> +    /* Hide the tap highlight to mitigate test differences due to when the snapshot

Nice!
Comment 9 Daniel Bates 2019-01-25 14:35:14 PST
Comment on attachment 360024 [details]
Patch and layout tests

Clearing flags on attachment: 360024

Committed r240512: <https://trac.webkit.org/changeset/240512>
Comment 10 Daniel Bates 2019-01-25 14:35:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-01-25 14:36:33 PST
<rdar://problem/47562134>