Summary: | [iOS] uiController.keyDown() does not translate Control modified key | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ews-watchlist, lforschler, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Local Build | ||||||||||||||
Hardware: | iPhone / iPad | ||||||||||||||
OS: | iOS 12 | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=192897 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 190571 | ||||||||||||||
Attachments: |
|
Description
Daniel Bates
2018-12-19 16:39:50 PST
Created attachment 359080 [details]
Patch
Comment on attachment 359080 [details] Patch Attachment 359080 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10749691 New failing tests: fast/text/scroll-text-overflow-ellipsis.html Created attachment 359096 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 359178 [details]
Patch and layout tests
Comment on attachment 359178 [details] Patch and layout tests Attachment 359178 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10761590 New failing tests: fast/text/scroll-text-overflow-ellipsis.html Created attachment 359191 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 360024 [details]
Patch and layout tests
Comment on attachment 360024 [details] Patch and layout tests View in context: https://bugs.webkit.org/attachment.cgi?id=360024&action=review > LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible-expected.html:7 > + /* Hide the tap highlight to mitigate test differences due to when the snapshot Nice! Comment on attachment 360024 [details] Patch and layout tests Clearing flags on attachment: 360024 Committed r240512: <https://trac.webkit.org/changeset/240512> All reviewed patches have been landed. Closing bug. |