| Summary: | [iOS] Interpret text key commands on keydown and app key commands on keypress | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | iOS 12 | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=192898 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 190571, 193679 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Daniel Bates
2018-12-19 16:34:57 PST
Created attachment 357755 [details] Patch I did not include a test for this change since we need to fix bug #192898 in order to support testing Control-modified key commands. Will upload a test that we can use once bug #192898 is fixed. We no longer need to check that we are interpreting a keydown event before calling the SPI as the SPI does this check for us. Created attachment 357756 [details] Layout test (once we fix bug #192898) Comment on attachment 357756 [details] Layout test (once we fix bug #192898) This layout test was written with the assumption that it would be placed in LayoutTests/fast/events/ios (or at least in a similar directory hierarchy). Comment on attachment 357755 [details]
Patch
Looks good. Do we need any UIKit changes to support this before landing?
(In reply to Brent Fulgham from comment #5) > Comment on attachment 357755 [details] > Patch > > Looks good. Do we need any UIKit changes to support this before landing? Yes, we need the fix for <rdar://problem/46854373>. Created attachment 358656 [details]
To Land
*** Bug 191768 has been marked as a duplicate of this bug. *** Comment on attachment 358656 [details] To Land Clearing flags on attachment: 358656 Committed r240285: <https://trac.webkit.org/changeset/240285> All reviewed patches have been landed. Closing bug. |