Bug 192875

Summary:

[GTK][WPE] Enable CSS typed OM

Product:

WebKit

Reporter:

Alicia Boya García <aboya>

Component:

WebKitGTK

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, bugs-noreply, cdumez, cgarcia, chi187, clopez, csaavedra, ews-watchlist, ggaren, graouts, gyuyoung.kim, ryuan.choi, sergio, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=190710

Bug Depends on:

Bug Blocks:

175733

Attachments:

Description	Flags
Patch	none

Description Alicia Boya García 2018-12-19 13:59:25 PST

New test failing:

css-typedom/attributeStyleMap.html

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-typedom/attributeStyleMap-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-typedom/attributeStyleMap-actual.txt
@@ -1,4 +1,4 @@
 
-PASS test that element.attributeStyleMap exists 
-PASS test that element.attributeStyleMap has a valid width value 
+FAIL test that element.attributeStyleMap exists assert_true: expected true got false
+FAIL test that element.attributeStyleMap has a valid width value undefined is not an object (evaluating 'el.attributeStyleMap.get')

Comment 1 Alicia Boya García 2018-12-19 16:42:49 PST

Same error in imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html. Interestingly, WebKit does not seem to support this feature very well according to the multiplatform expectations, but in this case somehow attributeStyleMap does not even exist, whereas in the general expectations its methods don't exist.

--- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt
+++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-actual.txt
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 63: TypeError: element.attributeStyleMap.clear is not a function. (In 'element.attributeStyleMap.clear()', 'element.attributeStyleMap.clear' is undefined)
+CONSOLE MESSAGE: line 63: TypeError: undefined is not an object (evaluating 'element.attributeStyleMap.clear')
 
-FAIL Untitled TypeError: element.attributeStyleMap.clear is not a function. (In 'element.attributeStyleMap.clear()', 'element.attributeStyleMap.clear' is undefined)
+FAIL Untitled TypeError: undefined is not an object (evaluating 'element.attributeStyleMap.clear')

Comment 2 Claudio Saavedra 2019-01-07 07:57:00 PST

I've skipped the css-typedom directory for now, once we enable the feature we have to revisit the tests.

Comment 3 Carlos Alberto Lopez Perez 2019-10-23 10:55:43 PDT

The implementation is tracked in bug 175733.
I think we can enable this for GTK/WPE as a experimental feature. The layout test pass after doing so.

Comment 4 Carlos Alberto Lopez Perez 2019-10-25 04:59:50 PDT

Created attachment 381909 [details]
Patch

Comment 5 Carlos Alberto Lopez Perez 2019-10-28 09:25:23 PDT

Comment on attachment 381909 [details]
Patch

Clearing flags on attachment: 381909

Committed r251656: <https://trac.webkit.org/changeset/251656>

Comment 6 Carlos Alberto Lopez Perez 2019-10-28 09:25:27 PDT

All reviewed patches have been landed.  Closing bug.