Bug 192398

Summary: Minor refactoring of the scrolling code
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: New BugsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176914, 192395    
Attachments:
Description Flags
Patch none

Frédéric Wang (:fredw)
Reported 2018-12-05 05:37:05 PST
Minor refactoring of the scrolling tree
Attachments
Patch (11.29 KB, patch)
2018-12-05 05:44 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-12-05 05:44:08 PST
Created attachment 356598 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-12-05 10:21:00 PST
Comment on attachment 356598 [details] Patch Clearing flags on attachment: 356598 Committed r238898: <https://trac.webkit.org/changeset/238898>
Simon Fraser (smfr)
Comment 3 2018-12-05 10:21:02 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-12-05 10:22:32 PST
<rdar://problem/46491395>
Frédéric Wang (:fredw)
Comment 5 2019-01-22 08:51:56 PST
Comment on attachment 356598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356598&action=review > Source/WebCore/page/scrolling/ScrollingStateTree.h:37 > +class ScrollingStateFrameScrollingNode; I think this has caused ScrollingStateScrollingNode.h from not being included from ScrollingTreeScrollingNode.cpp, hence possible build error when unified sources rotate. Will land a fix.
Frédéric Wang (:fredw)
Comment 6 2019-01-22 08:59:22 PST
Committed r240252: <https://trac.webkit.org/changeset/240252>
Note You need to log in before you can comment on or make changes to this bug.