Bug 192398

Summary: Minor refactoring of the scrolling code
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: New BugsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176914, 192395    
Attachments:
Description Flags
Patch none

Description Frédéric Wang (:fredw) 2018-12-05 05:37:05 PST 
Minor refactoring of the scrolling tree
Comment 1 Frédéric Wang (:fredw) 2018-12-05 05:44:08 PST 
Created attachment 356598 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-12-05 10:21:00 PST 
Comment on attachment 356598 [details]
Patch

Clearing flags on attachment: 356598

Committed r238898: <https://trac.webkit.org/changeset/238898>
Comment 3 Simon Fraser (smfr) 2018-12-05 10:21:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-12-05 10:22:32 PST 
<rdar://problem/46491395>
Comment 5 Frédéric Wang (:fredw) 2019-01-22 08:51:56 PST 
Comment on attachment 356598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356598&action=review

> Source/WebCore/page/scrolling/ScrollingStateTree.h:37
> +class ScrollingStateFrameScrollingNode;

I think this has caused ScrollingStateScrollingNode.h from not being included from ScrollingTreeScrollingNode.cpp, hence possible build error when unified sources rotate. Will land a fix.
Comment 6 Frédéric Wang (:fredw) 2019-01-22 08:59:22 PST 
Committed r240252: <https://trac.webkit.org/changeset/240252>