Bug 192306

Summary: [SOUP] Move URLSoup back to WebCore after r238771
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, keith_miller, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=190234
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2018-12-03 03:10:57 PST
In r238771 URL was moved from WebCore to WTF, including the soup implementation. Unfortunately that added libsoup as a new dependency of libjavascriptcoregtk.
Attachments
Patch (33.63 KB, patch)
2018-12-03 03:19 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-12-03 03:19:47 PST
Created attachment 356372 [details] Patch
Michael Catanzaro
Comment 2 2018-12-03 11:56:20 PST
Comment on attachment 356372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356372&action=review Thanks, good catch. Looks like this was not fun to fix. > Source/WebKit/PluginProcess/PluginProcess.cpp:42 > +#include <unistd.h> Probably this belongs inside an OS(UNIX) guard.
Alex Christensen
Comment 3 2018-12-03 13:14:37 PST
LGTM.
Carlos Garcia Campos
Comment 4 2018-12-04 03:01:25 PST
Committed r238851: <https://trac.webkit.org/changeset/238851>
Radar WebKit Bug Importer
Comment 5 2018-12-04 03:03:29 PST
<rdar://problem/46448678>
Note You need to log in before you can comment on or make changes to this bug.