Summary: | webkitpy: Use DeviceType instead of str to represent device class | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, dbates, ews-watchlist, glenn, lforschler, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 192257 | ||||||||
Attachments: |
|
Description
Jonathan Bedard
2018-11-29 09:45:34 PST
Created attachment 356084 [details]
Patch
rs=me Created attachment 356198 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 356198 [details]: inspector/audit/basic.html bug 192237 (author: drousso@apple.com) webgl/2.0.0/conformance/more/conformance/quickCheckAPI-B1.html bug 192238 (author: justin_fan@apple.com) inspector/dom-debugger/event-animation-frame-breakpoints.html bug 192221 (author: drousso@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 356198 [details]: inspector/layers/layer-tree-manager.html bug 192239 (authors: drousso@apple.com and ross.kirsling@sony.com) workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 356198 [details] Patch for landing Clearing flags on attachment: 356198 Committed r238749: <https://trac.webkit.org/changeset/238749> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #7) > Comment on attachment 356198 [details] > Patch for landing > > Clearing flags on attachment: 356198 > > Committed r238749: <https://trac.webkit.org/changeset/238749> This broke run-api-tests for iOS Simulator. See bug #192257. (In reply to Daniel Bates from comment #9) > (In reply to WebKit Commit Bot from comment #7) > > Comment on attachment 356198 [details] > > Patch for landing > > > > Clearing flags on attachment: 356198 > > > > Committed r238749: <https://trac.webkit.org/changeset/238749> > > This broke run-api-tests for iOS Simulator. See bug #192257. Thanks for the heads up...totally forgot that script used this too, fixing now. |