Bug 192257 – REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Ran `run-api-tests --debug --ios-simulator`. It dies with the following error:

AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS':

[[
$ Tools/Scripts/run-api-tests --debug --ios-simulator --no-build
Checking build ...
AttributeError raised: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
Traceback (most recent call last):
  File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 58, in main
    return run(port, options, args, stderr)
  File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 76, in run
    result = manager.run(args, json_output=options.json_output)
  File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/manager.py", line 163, in run
    self._initialize_devices()
  File "/Volumes/.../OpenSource/Tools/Scripts/webkitpy/api_tests/manager.py", line 132, in _initialize_devices
    SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string(self._port.DEFAULT_DEVICE_CLASS), allow_incomplete_match=True), self.host, simulator_ui=False)
AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
]]

[Radar WebKit Bug Importer]

<rdar://problem/46384671>

[Radar WebKit Bug Importer]

<rdar://problem/46384673>

[Jonathan Bedard]

Created attachment 356251 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 356251 [details]
Patch

Clearing flags on attachment: 356251

Committed r238763: <https://trac.webkit.org/changeset/238763>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.