Bug 192033

Summary: r238510 broke scopes of size zero
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ryanhaddad, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191958
Attachments:
Description Flags
patch none

Saam Barati
Reported 2018-11-27 13:42:35 PST
Because maxScopeOffset() for the SymbolTable will be UINT_MAX, this loop runs for UINT_MAX iterations: for (ScopeOffset offset { 0 }; offset <= symbolTable->maxScopeOffset(); offset += 1) { ... }
Attachments
patch (2.86 KB, patch)
2018-11-27 13:51 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-11-27 13:44:58 PST
<rdar://problem/46281734>
Saam Barati
Comment 2 2018-11-27 13:51:58 PST
Created attachment 355773 [details] patch
Keith Miller
Comment 3 2018-11-27 13:56:05 PST
r=me.
WebKit Commit Bot
Comment 4 2018-11-27 18:03:29 PST
Comment on attachment 355773 [details] patch Clearing flags on attachment: 355773 Committed r238596: <https://trac.webkit.org/changeset/238596>
WebKit Commit Bot
Comment 5 2018-11-27 18:03:31 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 6 2018-11-28 08:54:41 PST
*** Bug 192015 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.