Bug 191958

Summary: Object allocation sinking phase needs to iterate each scope offset instead of just iterating the symbol table's hashmap when handling an activation
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192033
Attachments:
Description Flags
patch
none
patch none

Description Saam Barati 2018-11-25 20:36:36 PST 
Otherwise, we may ignore duplicate entries in the map even though there was more than one scope offset created for them
Comment 1 Saam Barati 2018-11-25 20:37:17 PST 
<rdar://problem/46221877>
Comment 2 Saam Barati 2018-11-25 20:42:52 PST 
Created attachment 355617 [details]
patch
Comment 3 Saam Barati 2018-11-25 20:44:24 PST 
Created attachment 355618 [details]
patch
Comment 4 Yusuke Suzuki 2018-11-25 23:24:49 PST 
Comment on attachment 355618 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-11-26 12:14:50 PST 
Comment on attachment 355618 [details]
patch

Clearing flags on attachment: 355618

Committed r238510: <https://trac.webkit.org/changeset/238510>
Comment 6 WebKit Commit Bot 2018-11-26 12:14:52 PST 
All reviewed patches have been landed.  Closing bug.