| Summary: | Web Inspector: Timelines: flatten the overview to show all records, one per line | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||||
| OS: | All | ||||||||||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=191636 https://bugs.webkit.org/show_bug.cgi?id=191635 |
||||||||||||||||||||||||
| Bug Depends on: | 195959 | ||||||||||||||||||||||||
| Bug Blocks: | 215044 | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Devin Rousso
2018-11-21 18:21:27 PST
Created attachment 355450 [details]
Patch
Created attachment 355451 [details]
[Image] After Patch is applied
Created attachment 355452 [details]
Patch
Created attachment 355454 [details]
Patch
Created attachment 355609 [details]
Patch
We should be able to toggle between the grouped and non grouped views. There is an advantage of the grouped view at times (seeing which script is evaluating code and it’s affects. Likewise style invalidation and layout loops (In reply to Joseph Pecoraro from comment #6) > We should be able to toggle between the grouped and non grouped views. There > is an advantage of the grouped view at times (seeing which script is > evaluating code and it’s affects. Likewise style invalidation and layout > loops I agree. Considering the already large size of this patch, I was planning on having it be a followup, but the removal of some of the code/files in the patch may inhibit that. I'll look into adding it back to this patch. Comment on attachment 355609 [details]
Patch
r- for now, since this really should be an option to toggle between modes.
Created attachment 358176 [details]
Patch
I agree this should be a toggle. Both modes have their benefits. Created attachment 365237 [details]
Patch
Created attachment 365238 [details]
[Image] After Patch is applied
After looking at this more, I think there is information missing from the view now that is can be ungrouped. The records can be in any order now, so they really need some indication what resource they are from — where you will go if you click. I think showing them in the sidebar like: [S] Style Invalidated — [<>] webkit.org [S] Script Evaluated — [JS] global.js [S] Script Evaluated — [JS] wp-embed.min.js etc. (In reply to Timothy Hatcher from comment #14) > After looking at this more, I think there is information missing from the > view now that is can be ungrouped. The records can be in any order now, so > they really need some indication what resource they are from — where you > will go if you click. > > I think showing them in the sidebar like: > > [S] Style Invalidated — [<>] webkit.org > [S] Script Evaluated — [JS] global.js > [S] Script Evaluated — [JS] wp-embed.min.js > > etc. I like it! FWIW, we didn't used to show this because all of the script types were on the same line. I'll figure something out :) Created attachment 365500 [details]
Patch
Created attachment 365501 [details]
[Image] After Patch is applied
Comment on attachment 365500 [details] Patch Clearing flags on attachment: 365500 Committed r243301: <https://trac.webkit.org/changeset/243301> All reviewed patches have been landed. Closing bug. |