Bug 191777

Summary:

[Win] Reduce the use of WKSI library calls: CoreAnimation

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, bfulgham, commit-queue, ews-watchlist, pvollan, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

191718

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	zalan: review+, commit-queue: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none

Brent Fulgham

Reported 2018-11-16 14:42:21 PST

Move some ancient CoreAnimation code out of WKSI and into Open Source, like we did for iOS and macOS WebKit back in 2017. The WKSI really doesn't provide any benefits to us, and only serves as a road block for outside contributors and a failure point for our build process.

Attachments
Patch (10.58 KB, patch) 2018-11-16 16:13 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (10.60 KB, patch) 2018-11-16 16:18 PST, Brent Fulgham	zalan: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (9.90 MB, application/zip) 2018-11-16 22:30 PST, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-11-16 14:51:16 PST

<rdar://problem/46140542>

Brent Fulgham

Comment 2 2018-11-16 16:13:56 PST

Created attachment 355153 [details] Patch

Brent Fulgham

Comment 3 2018-11-16 16:18:01 PST

Created attachment 355154 [details] Patch

Brent Fulgham

Comment 4 2018-11-16 16:19:15 PST

Note: This patch removes the last vestiges of WebkitSystemInterface code in WebKit. We still need to change the build rules to avoid building the project, but nothing links to it or refers to the headers anymore.

alan baradlay

Comment 5 2018-11-16 18:59:02 PST

Comment on attachment 355154 [details] Patch rs=me

WebKit Commit Bot

Comment 6 2018-11-16 19:23:13 PST

Comment on attachment 355154 [details] Patch Rejecting attachment 355154 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 355154, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKitLegacy/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/10028273

EWS Watchlist

Comment 7 2018-11-16 22:30:09 PST

Comment on attachment 355154 [details] Patch Attachment 355154 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10029439 New failing tests: media/no-fullscreen-when-hidden.html

EWS Watchlist

Comment 8 2018-11-16 22:30:11 PST

Created attachment 355181 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 9 2018-11-17 07:33:58 PST

(In reply to Brent Fulgham from comment #4) > Note: This patch removes the last vestiges of WebkitSystemInterface code in > WebKit. We still need to change the build rules to avoid building the > project, but nothing links to it or refers to the headers anymore. Hooray!

Brent Fulgham

Comment 10 2018-11-17 14:29:37 PST

(In reply to Build Bot from comment #8) > Created attachment 355181 [details] > Archive of layout-test-results from ews126 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6 The test blame algorithm is faulty. Removing WKSI from windows-specific code can’t have any effect on iOS simulator builds.

WebKit Commit Bot

Comment 11 2018-11-26 09:43:26 PST

Comment on attachment 355154 [details] Patch Rejecting attachment 355154 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355154, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKitLegacy/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/10155232

WebKit Commit Bot

Comment 12 2018-11-26 10:16:07 PST

Comment on attachment 355154 [details] Patch Rejecting attachment 355154 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355154, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKitLegacy/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/10155711

Brent Fulgham

Comment 13 2018-11-26 10:27:31 PST

Committed r238501: <https://trac.webkit.org/changeset/238501>

Note You need to log in before you can comment on or make changes to this bug.