Bug 191606

Summary:

[WPE] Remove glib usage in PlatformKeyboardEventWPE.cpp

Product:

WebKit

Reporter:

Christopher Reid <chris.reid>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, cdumez, clopez, cmarcelo, commit-queue, darin, dbates, don.olmstead, ews-watchlist, mcatanzaro, rniwa, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra	none
Updated patch	none

Christopher Reid

Reported 2018-11-13 15:36:31 PST

This file is calling glib for converting uint32_t code points to WTFString which doesn't seem necessary.

Attachments
patch (3.79 KB, patch) 2018-11-13 15:58 PST, Christopher Reid	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.67 MB, application/zip) 2018-11-13 17:32 PST, EWS Watchlist	no flags	Details
Updated patch (2.57 KB, patch) 2018-11-13 17:41 PST, Christopher Reid	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Christopher Reid

Comment 1 2018-11-13 15:58:56 PST

Created attachment 354719 [details] patch

Christopher Reid

Comment 2 2018-11-13 16:09:04 PST

For this change, I was wondering if there's a case for using StringBuilder::append(UChar32) with ill-formed utf-32 values.

Christopher Reid

Comment 3 2018-11-13 17:15:08 PST

(In reply to Christopher Reid from comment #2) > For this change, I was wondering if there's a case for using > StringBuilder::append(UChar32) with ill-formed utf-32 values. It seems like CSS.escape does rely on this based on the test failures.

EWS Watchlist

Comment 4 2018-11-13 17:32:51 PST

Comment on attachment 354719 [details] patch Attachment 354719 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9979579 New failing tests: imported/w3c/web-platform-tests/css/cssom/escape.html css3/escape-dom-api.html

EWS Watchlist

Comment 5 2018-11-13 17:32:53 PST

Created attachment 354735 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

Christopher Reid

Comment 6 2018-11-13 17:41:39 PST

Created attachment 354737 [details] Updated patch

Michael Catanzaro

Comment 7 2018-11-13 18:02:18 PST

Comment on attachment 354737 [details] Updated patch This looks OK provided the file is first renamed to PlatformKeyboardEventLibWPE.cpp in bug #191401.

Don Olmstead

Comment 8 2018-11-13 18:10:54 PST

(In reply to Michael Catanzaro from comment #7) > Comment on attachment 354737 [details] > Updated patch > > This looks OK provided the file is first renamed to > PlatformKeyboardEventLibWPE.cpp in bug #191401. Yea I'll be doing that as a followup. This was to prepare it so this can land.

WebKit Commit Bot

Comment 9 2018-11-14 08:13:16 PST

Comment on attachment 354737 [details] Updated patch Clearing flags on attachment: 354737 Committed r238175: <https://trac.webkit.org/changeset/238175>

WebKit Commit Bot

Comment 10 2018-11-14 08:13:18 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2018-11-14 08:14:28 PST

<rdar://problem/46063349>

Note You need to log in before you can comment on or make changes to this bug.