Summary: | Import the Flexbox test suite from the W3C Web Platform Tests | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||||||||||||
Component: | Layout and Rendering | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | bfulgham, clopez, jfernandez, rego, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=211762 | ||||||||||||||||||
Attachments: |
|
Description
Javier Fernandez
2018-11-09 03:41:32 PST
Created attachment 397188 [details]
Patch
Trying EWS. Ignore
Created attachment 399095 [details]
Patch
test EWS, ignore
Created attachment 399326 [details]
Patch
test EWS, ignore
Created attachment 399357 [details]
Patch
test EWS, ignore
Comment on attachment 399357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399357&action=review > LayoutTests/ChangeLog:8 > + This imports WPT css-flexbox and de-deplicates flexbox tests Typo: s/de-deplicates/deduplicates/ > LayoutTests/ChangeLog:10 > + This its the complete list of tests de-duplicated. Typo: I believe hyphen is not needed, anyway it should be consistent with the one above. Created attachment 399676 [details]
Patch
Test EWS again. Hopefully green
Created attachment 399688 [details]
Patch
test EWS
Comment on attachment 399688 [details]
Patch
EWS green! asking for review now
Note: i think the style error is not valid.
Comment on attachment 399688 [details]
Patch
Fix the typo in the ChangeLog (deplicates->duplicates) before landing.
Created attachment 399730 [details]
Patch
patch for landing
Committed r261859: <https://trac.webkit.org/changeset/261859> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399730 [details]. |